Skip to content

Commit af2fa7d

Browse files
gabeiodougwilson
authored andcommitted
tests: handle errors within tests
1 parent d95275b commit af2fa7d

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

test/session.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1509,7 +1509,7 @@ describe('session()', function(){
15091509
.use(session({ secret: 'keyboard cat' }))
15101510
.use(function(req, res, next){
15111511
req.session.destroy(function(err){
1512-
if (err) throw err;
1512+
if (err) return next(err)
15131513
assert(!req.session, 'req.session after destroy');
15141514
res.end();
15151515
});
@@ -1529,7 +1529,7 @@ describe('session()', function(){
15291529
.use(function(req, res, next){
15301530
var id = req.session.id;
15311531
req.session.regenerate(function(err){
1532-
if (err) throw err;
1532+
if (err) return next(err)
15331533
assert.notEqual(id, req.session.id)
15341534
res.end();
15351535
});
@@ -1936,6 +1936,7 @@ describe('session()', function(){
19361936
request(app)
19371937
.get('/')
19381938
.expect(200, '1', function (err, res) {
1939+
if (err) return done(err)
19391940
var a = new Date(expires(res))
19401941
var b = new Date
19411942
var delta = a.valueOf() - b.valueOf()
@@ -1952,6 +1953,7 @@ describe('session()', function(){
19521953
.get('/')
19531954
.set('Cookie', val)
19541955
.expect(200, '2', function (err, res) {
1956+
if (err) return done(err)
19551957
var a = new Date(expires(res))
19561958
var b = new Date
19571959
var delta = a.valueOf() - b.valueOf()
@@ -1968,6 +1970,7 @@ describe('session()', function(){
19681970
.get('/')
19691971
.set('Cookie', val)
19701972
.expect(200, '3', function (err, res) {
1973+
if (err) return done(err)
19711974
var a = new Date(expires(res))
19721975
var b = new Date
19731976
var delta = a.valueOf() - b.valueOf()

0 commit comments

Comments
 (0)