Crate and feature lists in wasm CI loops can easily go stale
#2808
Sebastian Thiel (Byron)
announced in
Tasks
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Current behavior 😯
The
wasmjob definition inci.ymlcontains steps that loop over various subsets of crates and features. One of the lists of crates is rather long:gitoxide/.github/workflows/ci.yml
Lines 393 to 398 in 83e1b73
For that list especially, but also other lists of crates and of features, it looks like no mechanism is in place to keep the lists updated or to automatically determine if they are up to date. For example, a crate may gain or lose feature toggles across versions.
Expected behavior 🤔
I don't know if it would make sense to dynamically generate those lists of crates, but even if not, I think it would be good to have some way to verify if they are still accurate to their descriptions. This could be a new CI job, or a new
justfilerecipe, or a newjustfilerecipe that is called in a new CI job.(I don't think the check would depend on which
wasmtarget is used, which is why I do not suggest doing it in a new step of that job, which would cause it to be done twice. That could be done if it turns out to be clearer or more elegant overall, though.)Git behavior
Not applicable.
Steps to reproduce 🕹
For the general issue, see above.
As for the question of whether the lists are current as of now, I have not (yet?) investigated that.
Originally tracked by Eliah Kagan (@EliahKagan) in issue #1988.
All reactions