Repository navigation

SecondLargestElement Algorithm returns wrong value #1035

Closed

Labels

opened

for the array [-1, -2, -3, -4] it returns 0

appgurueu
added
bugSomething isn't working
on Jun 3, 2022
appgurueu
changed the title ~~[-]fix SecondLargestElement Algorithm[/-]~~ [+]SecondLargestElement Algorithm returns wrong value[/+] on Jun 3, 2022
appgurueu commented on Jun 3, 2022
appgurueu
on Jun 3, 2022
Collaborator
I assume the algorithm just wasn't intended to support negative values as it uses 0 as a default min value.
Ankush263 commented on Jun 3, 2022
Ankush263
on Jun 3, 2022
ContributorAuthor
Should I make a PR
appgurueu commented on Jun 3, 2022
appgurueu
on Jun 3, 2022
Collaborator

Should I make a PR

I've already fixed it, see the linked PR.
raklaptudirm
closed this as completedin #1036 on Jun 3, 2022

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests