Skip to content

Improper and incomplete implementation of CycleDetection.js #1097

Closed
#1099
Closed
Improper and incomplete implementation of CycleDetection.js#1097
#1099
Assignees
10kartik
Labels
code qualityCode quality improvement

Description

@10kartik
10kartik
opened on Sep 13, 2022

Implementation of CycleDetection.js seems inappropriate.

  • Weird function name main() and its invocation can cause the program to crash.
  • Tests are missing.
  • Not exported, Hence not resuable.
  • Can be optimized further (Optional)

Activity

  1. appgurueu
    added
    code qualityCode quality improvement
    on Sep 13, 2022

  2. appgurueu commented on Sep 13, 2022

    @appgurueu
    appgurueu
    on Sep 13, 2022
    Collaborator

    The algorithm is complete. It has poor code quality though, as you have pointed out. Feel free to fix it.

  3. raklaptudirm
    assigned
    10kartik
    on Sep 13, 2022
  4. raklaptudirm
    closed this as completedin #1099on Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

code qualityCode quality improvement

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions