Skip to content

Validate Url Issues #1183

Closed
#1335
Closed
Validate Url Issues#1183
#1335
Labels
bugSomething isn't working

Description

@meirroth
meirroth
opened on Oct 13, 2022

Two issues found with the Validate Url algorithm:

  1. A string is considered to be valid URL if it starts with www. even though it does not have https
  • validateUrl('www.google.com') // returns true
  • validateUrl('google.com') // returns false
  1. A valid URL returns false if starts with www like:
  • validateUrl('https://wwwdomain.com') // returns false

Activity

  1. appgurueu
    added
    bugSomething isn't working
    on Oct 13, 2022

  2. SubhamB2003 commented on Oct 16, 2022

    @SubhamB2003
    SubhamB2003
    on Oct 16, 2022

    Can i try this

  3. appgurueu commented on Oct 16, 2022

    @appgurueu
    appgurueu
    on Oct 16, 2022
    Collaborator

    Can i try this

    No (see the current PR).

  4. 609harsh commented on Oct 19, 2022

    @609harsh
    609harsh
    on Oct 19, 2022

    is it still open?

  5. appgurueu commented on Oct 19, 2022

    @appgurueu
    appgurueu
    on Oct 19, 2022
    Collaborator

    Yesn't? The solution might be a removal of the "algorithm" though.

  6. trasherdk commented on Oct 27, 2022

    @trasherdk
    trasherdk
    on Oct 27, 2022
    Contributor

    Hmm. None of those test cases are valid email addresses.

    validateEmail('www.google.com') // returns true ❓

  7. meirroth commented on Oct 27, 2022

    @meirroth
    meirroth
    on Oct 27, 2022
    Author

    @trasherdk Oops... It's a typo. Should say validateUrl('www.google.com').
    Fixed now.

  8. Aditya-Naresh commented on Apr 16, 2023

    @Aditya-Naresh
    Aditya-Naresh
    on Apr 16, 2023

    Is this issue still open?

  9. appgurueu commented on Apr 16, 2023

    @appgurueu
    appgurueu
    on Apr 16, 2023
    Collaborator

    Is this issue still open?

    Yes, but bear in mind that validating URLs is much more complex than presented here:

    URL syntax diagram

    (from https://en.wikipedia.org/wiki/URL)

  10. 0-harshit-0 commented on Jul 5, 2023

    @0-harshit-0
    0-harshit-0
    on Jul 5, 2023
    Contributor

    hello, I would like to work on this.

  11. raklaptudirm
    closed this as completedin #1335on Jul 14, 2023
  12. raklaptudirm
    added a commit that references this issue on Jul 14, 2023

    Remove URL validation (#1335)

    ecac786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions