diff --git a/composer.json b/composer.json index 59bb199..7ca4c65 100644 --- a/composer.json +++ b/composer.json @@ -42,7 +42,7 @@ }, "require-dev": { "ext-xdebug": "*", - "aplus/coding-standard": "^2.0", + "aplus/coding-standard": "^2.8", "ergebnis/composer-normalize": "^2.25", "jetbrains/phpstorm-attributes": "^1.0", "phpmd/phpmd": "^2.13", diff --git a/src/SaveHandler.php b/src/SaveHandler.php index 5422856..5a0d2b6 100644 --- a/src/SaveHandler.php +++ b/src/SaveHandler.php @@ -41,7 +41,7 @@ abstract class SaveHandler implements \SessionHandlerInterface, \SessionUpdateTi * * @var false|string */ - protected string | false $lockId = false; + protected false | string $lockId = false; /** * Tells if the session exists (if was read). * @@ -70,7 +70,7 @@ abstract class SaveHandler implements \SessionHandlerInterface, \SessionUpdateTi public function __construct( #[SensitiveParameter] array $config = [], - Logger $logger = null + ?Logger $logger = null ) { $this->prepareConfig($config); $this->logger = $logger; @@ -298,7 +298,7 @@ abstract public function destroy($id) : bool; * @return false|int Returns the number of deleted session data for success, * false for failure */ - abstract public function gc($max_lifetime) : int | false; + abstract public function gc($max_lifetime) : false | int; /** * Acquire a lock for a session id. diff --git a/src/SaveHandlers/DatabaseHandler.php b/src/SaveHandlers/DatabaseHandler.php index 2c1bd37..46ebdc0 100644 --- a/src/SaveHandlers/DatabaseHandler.php +++ b/src/SaveHandlers/DatabaseHandler.php @@ -299,7 +299,7 @@ public function destroy($id) : bool return true; } - public function gc($max_lifetime) : int | false + public function gc($max_lifetime) : false | int { try { $this->database ??= new Database($this->config); diff --git a/src/SaveHandlers/FilesHandler.php b/src/SaveHandlers/FilesHandler.php index 092eadb..f9fe8c5 100644 --- a/src/SaveHandlers/FilesHandler.php +++ b/src/SaveHandlers/FilesHandler.php @@ -187,7 +187,7 @@ public function destroy($id) : bool return !\is_file($filename) || \unlink($filename); } - public function gc($max_lifetime) : int | false + public function gc($max_lifetime) : false | int { $dirHandle = \opendir($this->config['directory']); if ($dirHandle === false) { diff --git a/src/SaveHandlers/MemcachedHandler.php b/src/SaveHandlers/MemcachedHandler.php index 948587d..2b02732 100644 --- a/src/SaveHandlers/MemcachedHandler.php +++ b/src/SaveHandlers/MemcachedHandler.php @@ -246,7 +246,7 @@ public function destroy($id) : bool && $this->memcached->getResultCode() !== Memcached::RES_NOTFOUND); } - public function gc($max_lifetime) : int | false + public function gc($max_lifetime) : false | int { return 0; } diff --git a/src/SaveHandlers/RedisHandler.php b/src/SaveHandlers/RedisHandler.php index 3b6d35f..f153dca 100644 --- a/src/SaveHandlers/RedisHandler.php +++ b/src/SaveHandlers/RedisHandler.php @@ -223,7 +223,7 @@ public function destroy($id) : bool return true; } - public function gc($max_lifetime) : int | false + public function gc($max_lifetime) : false | int { return 0; } diff --git a/src/Session.php b/src/Session.php index 469691f..7b34489 100644 --- a/src/Session.php +++ b/src/Session.php @@ -34,7 +34,7 @@ class Session * @param array $options * @param SaveHandler|null $handler */ - public function __construct(array $options = [], SaveHandler $handler = null) + public function __construct(array $options = [], ?SaveHandler $handler = null) { $this->setOptions($options); if ($handler) { @@ -553,7 +553,7 @@ public function removeTemp(string $key) : static * $newId is set, it is accepted but not validated. When session_start is * called, the id is only used if it is valid */ - public function id(string $newId = null) : string | false + public function id(?string $newId = null) : false | string { if ($newId !== null && $this->isActive()) { throw new LogicException( @@ -571,7 +571,7 @@ public function id(string $newId = null) : string | false * @return false|int Returns the number of deleted session data for success, * false for failure */ - public function gc() : int | false + public function gc() : false | int { return @\session_gc(); } diff --git a/tests/Debug/SessionCollectorTest.php b/tests/Debug/SessionCollectorTest.php index be5dbbe..486cada 100644 --- a/tests/Debug/SessionCollectorTest.php +++ b/tests/Debug/SessionCollectorTest.php @@ -39,7 +39,7 @@ protected function setUp() : void * * @return Session */ - protected function makeSession(array $options = [], SaveHandler $handler = null) : Session + protected function makeSession(array $options = [], ?SaveHandler $handler = null) : Session { $session = new Session($options, $handler); $session->setDebugCollector($this->collector); @@ -208,7 +208,7 @@ public function destroy($id) : bool return true; } - public function gc($maxLifetime) : int | false + public function gc($maxLifetime) : false | int { return 0; } diff --git a/tests/SaveHandlers/DatabaseHandlerTest.php b/tests/SaveHandlers/DatabaseHandlerTest.php index 18781c9..b18e2e6 100644 --- a/tests/SaveHandlers/DatabaseHandlerTest.php +++ b/tests/SaveHandlers/DatabaseHandlerTest.php @@ -148,7 +148,7 @@ public function unlock() : bool public function testFailToUnlock() : void { $handler = new class($this->config) extends DatabaseHandler { - public string | false $lockId; + public false | string $lockId; public function unlock() : bool { diff --git a/tests/SaveHandlers/MemcachedHandlerTest.php b/tests/SaveHandlers/MemcachedHandlerTest.php index a45b875..7d41ad1 100644 --- a/tests/SaveHandlers/MemcachedHandlerTest.php +++ b/tests/SaveHandlers/MemcachedHandlerTest.php @@ -144,7 +144,7 @@ public function testFailToWrite() : void public function testUnlocked() : void { $handler = new class($this->config) extends MemcachedHandler { - public string | false $lockId; + public false | string $lockId; public function unlock() : bool { @@ -160,7 +160,7 @@ public function testReplaceLock() : void { $handler = new class($this->config, $this->logger) extends MemcachedHandler { public ?Memcached $memcached; - public string | false $lockId; + public false | string $lockId; public function lock(string $id) : bool { @@ -176,7 +176,7 @@ public function lock(string $id) : bool public function testFailToDestroy() : void { $handler = new class($this->config) extends MemcachedHandler { - public string | false $lockId; + public false | string $lockId; }; $handler->lockId = false; self::assertFalse($handler->destroy('foo')); diff --git a/tests/SaveHandlers/RedisHandlerTest.php b/tests/SaveHandlers/RedisHandlerTest.php index 54a301f..0122bd7 100644 --- a/tests/SaveHandlers/RedisHandlerTest.php +++ b/tests/SaveHandlers/RedisHandlerTest.php @@ -119,7 +119,7 @@ public function testFailToClose() : void public function testUnlock() : void { $handler = new class($this->config, $this->logger) extends RedisHandler { - public string | false $lockId; + public false | string $lockId; public function unlock() : bool {