You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
.textConverted needs to install the package encoding separately #412
Please note that since encoding is not part of the dependencies by default, when using this package with webpack, without installing encoding, webpack will fail with the usual error message:
WARNING in ./node_modules/cross-fetch/node_modules/node-fetch/lib/index.es.js
Module not found: Error: Can't resolve 'encoding' in 'C:\git\halo.site\node_modules\cross-fetc
h\node_modules\node-fetch\
I think it would be nice to also add this to the README:
When using node-fetch with webpack. You either need to install encoding or add IgnorePlugin
Reacted by Filippo Conti, Rhian van Esch, Kyle Spearrin, Flamenco, Than Hutchins, Rocco Musolino, Danny Hurlburt, Phil A., The web walker, Mauricio Navarro Miranda and 11 more
Activity
TimothyGu commentedon Mar 4, 2018
It's intentional: we don't force people who don't use
textConvertedto installencoding. We should document this however.motss commentedon Mar 5, 2018
Ya. A line or two stating this can be helpful! 👍
TimothyGu commentedon Mar 5, 2018
@motss Would you be interested in creating a pull request?☺️
motss commentedon Mar 6, 2018
@TimothyGu Sure thing. Will work on that probably on the weekend.
The readme update discussion PR
peterbakonyi05 commentedon Apr 5, 2018
Please note that since
encodingis not part of the dependencies by default, when using this package withwebpack, without installingencoding, webpack will fail with the usual error message:I think it would be nice to also add this to the
README:When using
node-fetchwithwebpack. You either need to installencodingor add IgnorePluginitonics-tbeauvais commentedon Aug 28, 2018
Somehow, using the
nodeExternals()for theexternalsoption in webpack found here https://www.npmjs.com/package/webpack-node-externalsmotss commentedon Aug 28, 2018
I thought this had been fixed by one of the PRs. I can update the doc real quick with the findings from @peterbakonyi05 as well.
motss commentedon Aug 28, 2018
I've added briefly in the doc. Please help review #511. Thank you.
bitinn commentedon Nov 5, 2018
I have added guideline to readme and link to this issue.