Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codelucas/newspaper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.4
Choose a base ref
...
head repository: codelucas/newspaper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.5
Choose a head ref
  • 13 commits
  • 5 files changed
  • 2 contributors

Commits on Jan 15, 2015

  1. Fixed empty return in top_meta_image 

    Return empty unicode in ContentExtractor.top_meta_image() when no image is found. It was returning the article's url.

Example:
http://www.usnews.com/news/entertainment/articles/2015/01/15/boyhood-keaton-moore-are-oscar-favorites-in-vegas
(note that USNews often updates its articles, e.g. by adding an image -- at the time of writing it was without images)
    @0x0ece
    0x0ece committed Jan 15, 2015
    Configuration menu
    Copy the full SHA
    e408b86 View commit details
    Browse the repository at this point in the history

  2. Fix nodeToString() to return valid HTML 

    In some cases the output of nodeToString() is not valid HTML, e.g. for iframe nodes.

Solution found here: http://stackoverflow.com/questions/27020950/lxml-modify-tags-prevent

An example of bad behavior is an article with a youtube video inside. The video embed code is transformed into `<iframe ... />`, that is not valid, and thus the result in the browser is a page with no visible content after the video.
    @0x0ece
    0x0ece committed Jan 15, 2015
    Configuration menu
    Copy the full SHA
    5cdc5d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2015

  1. Allow lists in clean_article_html() - fixes #108

    @0x0ece
    0x0ece committed Jan 18, 2015
    Configuration menu
    Copy the full SHA
    b4711d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2015

  1. [bugfix] Handle None and empty str in get_unicode_html

    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    f01fda9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'patch-2' of https://github.com/ecesena/newspaper into e… 

    …cesena-patch-2
    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    8d23ef2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ecesena-patch-2'

    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    4f76150 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'patch-1' of https://github.com/ecesena/newspaper into e… 

    …cesena-top-meta-img
    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    1e3d62d View commit details
    Browse the repository at this point in the history

  5. Fix default return str in get_meta_img_url

    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    9beb5aa View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ecesena-top-meta-img'

    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    9fb9b9e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'patch-3' of https://github.com/ecesena/newspaper into e… 

    …cesena-include-li-article-html
    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    c5fac04 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'ecesena-include-li-article-html'

    @codelucas
    codelucas committed Feb 6, 2015
    Configuration menu
    Copy the full SHA
    8c15a53 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2015

  1. Update nltk 3.0.0 => 3.0.1, issue #121

    @codelucas
    codelucas committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    11885fd View commit details
    Browse the repository at this point in the history

  2. Version bump (just for the NLTK build fix)

    @codelucas
    codelucas committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    48d6667 View commit details
    Browse the repository at this point in the history
Loading