Skip to content

Commit d03365c

Browse files
authored
Improve README and CONTRIBUTING (#300)
* Update README.md Fixes part of #286 Signed-off-by: Jacob Hummer <jcbhmr@outlook.com> * Update CONTRIBUTING.md Signed-off-by: Jacob Hummer <jcbhmr@outlook.com> --------- Signed-off-by: Jacob Hummer <jcbhmr@outlook.com>
1 parent cca03ed commit d03365c

2 files changed

Lines changed: 95 additions & 72 deletions

File tree

CONTRIBUTING.md

Lines changed: 31 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,38 @@
1-
<div align="center">
2-
3-
[Overview](https://github.com/devcontainers-contrib/features#readme)
4-
| [User docs](https://github.com/devcontainers-contrib/features#usage)
5-
| **[Contributing](https://github.com/devcontainers-contrib/features/blob/main/CONTRIBUTING.md)**
6-
| [Developer wiki](https://github.com/devcontainers-contrib/features/wiki)
7-
8-
</div>
9-
101
**First off, thanks for taking the time to contribute! ❤️**
112

12-
All types of contributions are encouraged and valued, no matter if it's a bug report 🐛, a feature request 💡, or a Pull Request 🚀.
3+
All types of contributions are encouraged and valued, no matter if it's a bug
4+
report 🐛, a feature request 💡, or a Pull Request 🚀.
135

14-
-[I have a question](https://github.com/devcontainers-contrib/features/discussions/new?category=q-a)
15-
- 🐛 [I want to submit a bug report](https://github.com/devcontainers-contrib/features/issues/new)
16-
- 💡 [I want to suggest a feature](https://github.com/devcontainers-contrib/features/issues/new)
17-
- 🚀 [I want to contribute](https://github.com/devcontainers-contrib/features/wiki)
6+
<!-- prettier-ignore-start -->
7+
- **❓ I have a question:** [Open a Discussion](https://github.com/devcontainers-contrib/features/discussions/new?category=q-a)
8+
- **🐛 I found a bug:** [Open an Issue](https://github.com/devcontainers-contrib/features/issues/new)
9+
- **💡 I want to request a new feature:** [Open an Issue](https://github.com/devcontainers-contrib/features/issues/new)
10+
- **💻 I want to add a new feature:** [See below](#adding-a-feature)
11+
<!-- prettier-ignore-end -->
1812

19-
If you like the project, but just don't have time to contribute, that's OK too! You can also star the project ⭐, tweet about it 💬, or backlink to our repository 🔗.
13+
If you like the project, but just don't have time to contribute, that's OK too!
14+
You can also star the project ⭐, rave about it online 💬, or add a link to us
15+
🔗 in your project's readme.
2016

2117
⚠️ You must never report security 🔒 related issues, vulnerabilities or bugs
2218
including sensitive information to the issue tracker, or elsewhere in public.
23-
Instead sensitive bugs must be sent by email to <devcontainers.contrib+features.security@gmail.com>.
24-
25-
👩‍⚖️ When contributing to this project, you must agree that you have authored 100%
26-
of the content, that you have the necessary rights to the content and that the
27-
content you contribute may be provided under the project license.
19+
Instead sensitive bugs must be sent by email to
20+
devcontainers.contrib+features.security@gmail.com.
21+
22+
## Adding a feature
23+
24+
1. 🔀 Fork the repo
25+
2. 💻 Open the repo in your editor
26+
3. 👨‍💻 Follow the [How to add a feature] guide on the dev wiki
27+
4. ✨ Run the tests to make sure everything works
28+
5. 🔖 Commit & push your changes
29+
6. 🔁 Open a PR to get your changes merged
30+
7. 🚀 Profit!
31+
32+
👩‍⚖️ When contributing code to this project, you must agree that you have authored
33+
100% of the content, that you have the necessary rights to the content and that
34+
the content you contribute may be provided under the project license.
35+
36+
<!-- prettier-ignore-start -->
37+
[how to add a feature]: https://github.com/devcontainers-contrib/features/wiki/How-to-add-a-feature
38+
<!-- prettier-ignore-end -->

README.md

Lines changed: 64 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,77 +1,89 @@
11
# Community devcontainer features
22

3-
[![Gitter](https://img.shields.io/gitter/room/devcontainers-contrib/community?style=for-the-badge&logo=appveyor)](https://gitter.im/devcontainers-contrib/community)
4-
![Codespaces](https://img.shields.io/static/v1?style=for-the-badge&message=Codespaces&color=181717&logo=GitHub&logoColor=FFFFFF&label=)
5-
![Devcontainers](https://img.shields.io/static/v1?style=for-the-badge&message=Devcontainers&color=2496ED&logo=Docker&logoColor=FFFFFF&label=)
6-
![Python](https://img.shields.io/static/v1?style=for-the-badge&message=Python&color=3776AB&logo=Python&logoColor=FFFFFF&label=)
7-
8-
🐳 Extra add-in features for
9-
[devcontainers](https://code.visualstudio.com/docs/devcontainers/containers) and
10-
[GitHub Codespaces](https://github.com/features/codespaces)
3+
🧰 Feature addons for [@devcontainers]
114

125
<div align="center">
136

14-
![](https://i.imgur.com/W7t3YsC.png)
7+
![](https://i.imgur.com/VgiY81S.png)
158

16-
**[Overview](https://github.com/devcontainers-contrib/features#readme)** |
17-
[User docs](https://github.com/devcontainers-contrib/features#usage) |
18-
[Contributing](https://github.com/devcontainers-contrib/features/blob/main/CONTRIBUTING.md)
19-
| [Developer wiki](https://github.com/devcontainers-contrib/features/wiki)
9+
<!-- prettier-ignore -->
10+
[How to use a feature](https://code.visualstudio.com/blogs/2022/09/15/dev-container-features#_adding-features-to-your-dev-container)
11+
| [List of features](https://github.com/devcontainers-contrib/features/tree/main/src) <!-- CHANGE THIS TO GITHUB PAGES WHEN #284 IS MERGED! -->
12+
| [Contributing](https://github.com/devcontainers-contrib/features/blob/main/CONTRIBUTING.md)
13+
| [Dev wiki](https://github.com/devcontainers-contrib/features/wiki)
14+
| [Chat](https://gitter.im/devcontainers-contrib/community)
2015

2116
</div>
2217

23-
💻 Works with
24-
[devcontainers](https://code.visualstudio.com/docs/devcontainers/containers) \
25-
☁️ Works with [GitHub Codespaces](https://github.com/features/codespaces) \
26-
27-
📢 [We are actively seeking contributions!](CONTRIBUTING.md)
28-
29-
30-
## Contributing guide 😊
31-
32-
## A Handcrafted Feature
33-
34-
- Add a feature-id named directory to the [src folder](src/) containing your `devcontainer-feature.json` and `install.sh` scripts
35-
- Add the corresponsing test.sh to the [test folder](tests/)
36-
37-
## An Easily Generated Feature
38-
39-
Get the devcontainer-contrib cli
40-
```shell
41-
pip install devcontainer-contrib
42-
```
43-
44-
Add a new [`devcontainer-definition.json`](https://github.com/devcontainers-contrib/cli#readme) file to the [feature_definition dir](feature_definitions/)
45-
46-
While under the root folder of this repo, generate it using the command:
47-
```shell
48-
devcontainer-contrib features generate "./feature_definition/your-feature-id/feature-definition.json" "." --output-type=feature_dir
49-
```
50-
51-
[Additional information and docs about the CLI and devcontainer-definition.json file](https://github.com/devcontainers-contrib/cli#readme)
18+
💻 Works with [devcontainers] \
19+
☁️ Works with [GitHub Codespaces] \
20+
⚠️ We only officially support [debian]-based images
5221

22+
👀 Don't see your feature here? [Add it yourself] or [open an Issue]!
5323

5424
## Usage
5525

26+
![VS Code](https://img.shields.io/static/v1?style=for-the-badge&message=VS+Code&color=007ACC&logo=Visual+Studio+Code&logoColor=FFFFFF&label=)
27+
![Codespaces](https://img.shields.io/static/v1?style=for-the-badge&message=Codespaces&color=181717&logo=GitHub&logoColor=FFFFFF&label=)
28+
![Devcontainers](https://img.shields.io/static/v1?style=for-the-badge&message=Devcontainers&color=2496ED&logo=Docker&logoColor=FFFFFF&label=)
5629

57-
📄 [View the full list of features](src/)
30+
📄 [Complete feature list]
5831

5932
Just add a `.devcontainer/devcontainer.json` file with a `features` key. It's
60-
very similar to NPM's `package.json` and `dependencies` object, just with the
61-
addition of an `options` object.
33+
very similar to `package.json`'s `dependencies` object, just with the addition
34+
of an `options` object.
6235

63-
📚 Make sure to inspect each feature for feature-specific options \
64-
⚠️ We only officially support [debian](https://hub.docker.com/_/debian)-based images
36+
📚 Make sure to inspect each feature for feature-specific options!
6537

6638
```json
6739
{
68-
"image": "mcr.microsoft.com/devcontainers/universal:linux",
40+
"image": "mcr.microsoft.com/devcontainers/universal",
6941
"features": {
70-
"ghcr.io/devcontainers-contrib/features/deno:latest": {},
71-
"ghcr.io/devcontainers-contrib/features/mkdocs:latest": {},
72-
"ghcr.io/devcontainers-contrib/features/bikeshed:latest": {}
42+
"ghcr.io/devcontainers-contrib/features/deno:": {},
43+
"ghcr.io/devcontainers-contrib/features/neovim": {}
7344
}
7445
}
7546
```
7647

77-
## You can find more developer-specific docs on the [Wiki!](https://github.com/devcontainers-contrib/features/wiki) (thank you [@jcbhmr](https://github.com/jcbhmr)!)
48+
Then, after adding your devcontainer config file, you can open it in GitHub
49+
Codespaces, or [open it locally using VS Code]. Be warned some features will
50+
compile things from source code and may take a while!
51+
52+
<div align="center">
53+
54+
![](https://i.imgur.com/JMdowst.png)
55+
56+
</div>
57+
58+
## Development
59+
60+
![Devcontainers](https://img.shields.io/static/v1?style=for-the-badge&message=Devcontainers&color=2496ED&logo=Docker&logoColor=FFFFFF&label=)
61+
![JSON](https://img.shields.io/static/v1?style=for-the-badge&message=JSON&color=000000&logo=JSON&logoColor=FFFFFF&label=)
62+
![Bash](https://img.shields.io/static/v1?style=for-the-badge&message=Bash&color=4EAA25&logo=GNU+Bash&logoColor=FFFFFF&label=)
63+
64+
➕ Looking to add a new feature? Check out the [contributing guide]!
65+
66+
This project uses a devcontainer config to outline the development environment.
67+
We also provide various VS Code customizations for your coding pleasure.
68+
69+
To get started, create a GitHub Codespace on a copy of this repository. From
70+
there, the [dev wiki] provides information about adding features, layout,
71+
conventions, etc. When or if you want to contribute your changes back to this
72+
repository, you can follow the [contributing guide]. Happy coding! 👋
73+
74+
🗺️ If you're looking for a more thorough outline of how this repo works, check
75+
out the [How it works] page on the dev wiki.
76+
77+
<!-- prettier-ignore-start -->
78+
[@devcontainers]: https://github.com/devcontainers
79+
[add it yourself]: https://github.com/devcontainers-contrib/features/wiki/How-to-add-a-feature
80+
[open an issue]: https://github.com/devcontainers-contrib/features/issues/new
81+
[complete feature list]: https://github.com/devcontainers-contrib/features/tree/main/src
82+
[debian]: https://hub.docker.com/_/debian
83+
[open it locally using vs code]: https://code.visualstudio.com/docs/devcontainers/containers#_quick-start-open-an-existing-folder-in-a-container
84+
[contributing guide]: CONTRIBUTING.md
85+
[how it works]: https://github.com/devcontainers-contrib/features/wiki/How-it-works
86+
[dev wiki]: https://github.com/devcontainers-contrib/features/wiki
87+
[devcontainers]: https://containers.dev/
88+
[github codespaces]: https://github.com/features/codespaces
89+
<!-- prettier-ignore-end -->

0 commit comments

Comments
 (0)