Skip to content

Commit 3a554b8

Browse files
Java: fix gradle bug - invalid version (#84)
* Java: fix gradle bug - invalid version * drop 'lts'
1 parent abfefdc commit 3a554b8

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/java/devcontainer-feature.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
{
22
"id": "java",
3-
"version": "1.0.0",
3+
"version": "1.0.1",
44
"name": "Java (via SDKMAN!)",
55
"description": "Installs Java, SDKMAN! (if not installed), and needed dependencies.",
66
"options": {
77
"version": {
88
"type": "string",
99
"proposals": [
10-
"lts",
1110
"latest",
1211
"none",
1312
"17",
1413
"11",
1514
"8"
1615
],
17-
"default": "lts",
16+
"default": "latest",
1817
"description": "Select or enter a Java version to install"
1918
},
2019
"install_gradle": {

src/java/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ sdk_install() {
100100
local set_as_default=${6:-"true"}
101101
if [ "${requested_version}" = "none" ]; then return; fi
102102
# Blank will install latest stable version SDKMAN has
103-
if [ "${requested_version}" = "lts" ] || [ "${requested_version}" = "default" ]; then
103+
if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "lts" ] || [ "${requested_version}" = "default" ]; then
104104
requested_version=""
105105
elif echo "${requested_version}" | grep -oE "${full_version_check}" > /dev/null 2>&1; then
106106
echo "${requested_version}"

test-scenarios/install_gradle_and_maven.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ set -e
55
# Optional: Import test library
66
source dev-container-features-test-lib
77

8+
check "java" java --version
89
check "gradle" gradle --version
910
check "maven" mvn --version
1011

test-scenarios/scenarios.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"image": "ubuntu:focal",
44
"features": {
55
"java": {
6-
"version": "17",
6+
"version": "latest",
77
"install_gradle": true,
88
"install_maven": true
99
}

0 commit comments

Comments
 (0)