Node: Fix failure when version:none (#247)

fix version:none

Author: samruddhikhandale

src/node/devcontainer-feature.json

@@ -1,6 +1,6 @@
 {
     "id": "node",
-    "version": "1.1.0",
+    "version": "1.1.1",
     "name": "Node.js (via nvm) and yarn",
     "documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
     "description": "Installs Node.js, nvm, yarn, and needed dependencies.",

src/node/install.sh

@@ -205,6 +205,7 @@ rm -rf /var/lib/apt/lists/*
 # Ensure privs are correct for installed node versions. Unfortunately the
 # way nvm installs node versions pulls privs from the tar which does not
 # have group write set. We need this when the gid/uid is updated.
+mkdir -p "${NVM_DIR}/versions"
 chmod -R g+rw "${NVM_DIR}/versions"
 
 echo "Done!"

test/node/scenarios.json

@@ -16,5 +16,14 @@
                 "version": "latest"
             }
         }
+    },
+    "version_none": {
+        "image": "mcr.microsoft.com/devcontainers/base",
+        "remoteUser": "vscode",
+        "features": {
+            "node": {
+                "version": "none"
+            }
+        }
     }
 }

test/node/version_none.sh

@@ -0,0 +1,12 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+# Definition specific tests
+check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"
+
+# Report result
+reportResults