From 12dea7ea2f1257e2a79420ce274a3214f2fbbb82 Mon Sep 17 00:00:00 2001 From: Justin Yoo Date: Tue, 4 Oct 2022 01:17:59 +0000 Subject: [PATCH 1/3] Update NVM_VERSION to use the latest --- src/node/install.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/node/install.sh b/src/node/install.sh index 8eae62ea3..0e7b1620e 100755 --- a/src/node/install.sh +++ b/src/node/install.sh @@ -18,7 +18,8 @@ ADDITIONAL_VERSIONS=${ADDITIONALVERSIONS:-""} USERNAME=${USERNAME:-"automatic"} UPDATE_RC=${UPDATE_RC:-"true"} -export NVM_VERSION="0.38.0" +export NVM_VERSION=$(curl -H "Accept: application/vnd.github.v3+json" \ + https://api.github.com/repos/nvm-sh/nvm/releases/latest | jq -r '.tag_name') set -e @@ -126,7 +127,7 @@ su ${USERNAME} -c "$(cat << EOF umask 0002 # Do not update profile - we'll do this manually export PROFILE=/dev/null - curl -so- https://raw.githubusercontent.com/nvm-sh/nvm/v${NVM_VERSION}/install.sh | bash + curl -so- https://raw.githubusercontent.com/nvm-sh/nvm/${NVM_VERSION}/install.sh | bash source ${NVM_DIR}/nvm.sh if [ "${NODE_VERSION}" != "" ]; then nvm alias default ${NODE_VERSION} From 2e8edb59af4aeb0bba74780fe8866e0649f033a3 Mon Sep 17 00:00:00 2001 From: Justin Yoo Date: Tue, 4 Oct 2022 01:54:29 +0000 Subject: [PATCH 2/3] Add feature for test --- .devcontainer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer.json b/.devcontainer.json index d5d850ca5..311b2eee0 100644 --- a/.devcontainer.json +++ b/.devcontainer.json @@ -9,7 +9,8 @@ } }, "features": { - "ghcr.io/devcontainers/features/docker-in-docker:1": {} + "ghcr.io/devcontainers/features/docker-in-docker:1": {}, + "./src/node": {} }, "postCreateCommand": "npm install -g @devcontainers/cli" } From d69a9fbed5637cc34bb9ceeeb4d57d3340417a1e Mon Sep 17 00:00:00 2001 From: Justin Yoo Date: Tue, 4 Oct 2022 11:15:43 +0900 Subject: [PATCH 3/3] Revert .devcontainer.json --- .devcontainer.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.devcontainer.json b/.devcontainer.json index 311b2eee0..d5d850ca5 100644 --- a/.devcontainer.json +++ b/.devcontainer.json @@ -9,8 +9,7 @@ } }, "features": { - "ghcr.io/devcontainers/features/docker-in-docker:1": {}, - "./src/node": {} + "ghcr.io/devcontainers/features/docker-in-docker:1": {} }, "postCreateCommand": "npm install -g @devcontainers/cli" }