diff --git a/src/node/devcontainer-feature.json b/src/node/devcontainer-feature.json index cdc2fec6d..538ecb252 100644 --- a/src/node/devcontainer-feature.json +++ b/src/node/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "node", - "version": "1.1.0", + "version": "1.1.1", "name": "Node.js (via nvm) and yarn", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/node", "description": "Installs Node.js, nvm, yarn, and needed dependencies.", diff --git a/src/node/install.sh b/src/node/install.sh index cc5e1dc9e..f51306ebe 100755 --- a/src/node/install.sh +++ b/src/node/install.sh @@ -205,6 +205,7 @@ rm -rf /var/lib/apt/lists/* # Ensure privs are correct for installed node versions. Unfortunately the # way nvm installs node versions pulls privs from the tar which does not # have group write set. We need this when the gid/uid is updated. +mkdir -p "${NVM_DIR}/versions" chmod -R g+rw "${NVM_DIR}/versions" echo "Done!" diff --git a/test/node/scenarios.json b/test/node/scenarios.json index 8f93d8273..1240e61cc 100644 --- a/test/node/scenarios.json +++ b/test/node/scenarios.json @@ -16,5 +16,14 @@ "version": "latest" } } + }, + "version_none": { + "image": "mcr.microsoft.com/devcontainers/base", + "remoteUser": "vscode", + "features": { + "node": { + "version": "none" + } + } } } \ No newline at end of file diff --git a/test/node/version_none.sh b/test/node/version_none.sh new file mode 100755 index 000000000..c7c9e57f4 --- /dev/null +++ b/test/node/version_none.sh @@ -0,0 +1,12 @@ +#!/bin/bash + +set -e + +# Optional: Import test library +source dev-container-features-test-lib + +# Definition specific tests +check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10" + +# Report result +reportResults