From 1b6a4cf38a929334ea2b4fdc4245540b8cb93364 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Wed, 29 May 2024 11:09:06 +0000 Subject: [PATCH 1/5] [Java] - Document additionalVersions functionality --- src/java/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/src/java/README.md b/src/java/README.md index 938cd0f89..bea67b6a7 100644 --- a/src/java/README.md +++ b/src/java/README.md @@ -16,6 +16,7 @@ Installs Java, SDKMAN! (if not installed), and needed dependencies. | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| | version | Select or enter a Java version to install | string | latest | +| additionalVersions | Comma separated list of additional versions to install | string | empty | | jdkDistro | Select or enter a JDK distribution | string | ms | | installGradle | Install Gradle, a build automation tool for multi-language software development | boolean | false | | gradleVersion | Select or enter a Gradle version | string | latest | From cfc29f97f8383a4c07f47d4500bcb906e4c766ab Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Thu, 30 May 2024 03:48:42 +0000 Subject: [PATCH 2/5] changes requested --- src/java/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/java/README.md b/src/java/README.md index bea67b6a7..938cd0f89 100644 --- a/src/java/README.md +++ b/src/java/README.md @@ -16,7 +16,6 @@ Installs Java, SDKMAN! (if not installed), and needed dependencies. | Options Id | Description | Type | Default Value | |-----|-----|-----|-----| | version | Select or enter a Java version to install | string | latest | -| additionalVersions | Comma separated list of additional versions to install | string | empty | | jdkDistro | Select or enter a JDK distribution | string | ms | | installGradle | Install Gradle, a build automation tool for multi-language software development | boolean | false | | gradleVersion | Select or enter a Gradle version | string | latest | From 782f0db797f3aba77b1f774086111aa945f354bd Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Fri, 31 May 2024 14:24:13 +0000 Subject: [PATCH 3/5] changes as requested in pr review --- src/java/devcontainer-feature.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/java/devcontainer-feature.json b/src/java/devcontainer-feature.json index 9ed72ad59..11514cc5b 100644 --- a/src/java/devcontainer-feature.json +++ b/src/java/devcontainer-feature.json @@ -17,6 +17,14 @@ "default": "latest", "description": "Select or enter a Java version to install" }, + "additionalVersions": { + "type": "string", + "proposals": [ + "17, 8" + ], + "default": "", + "description": "Select or enter additional Java versions to install" + }, "jdkDistro": { "type": "string", "proposals": [ From 7a962ae137fef57781626d79ff7fe0fcb9ba1467 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Fri, 31 May 2024 14:27:23 +0000 Subject: [PATCH 4/5] bump patch version --- src/java/devcontainer-feature.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/java/devcontainer-feature.json b/src/java/devcontainer-feature.json index 11514cc5b..ec84b8c5d 100644 --- a/src/java/devcontainer-feature.json +++ b/src/java/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "java", - "version": "1.4.1", + "version": "1.4.2", "name": "Java (via SDKMAN!)", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/java", "description": "Installs Java, SDKMAN! (if not installed), and needed dependencies.", From dc0251d04da2fe59abfec489b0caf30450424505 Mon Sep 17 00:00:00 2001 From: Gaurav Saini <147703805+gauravsaini04@users.noreply.github.com> Date: Mon, 3 Jun 2024 02:41:08 +0000 Subject: [PATCH 5/5] changes requested --- src/java/devcontainer-feature.json | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/java/devcontainer-feature.json b/src/java/devcontainer-feature.json index ec84b8c5d..c43862610 100644 --- a/src/java/devcontainer-feature.json +++ b/src/java/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "java", - "version": "1.4.2", + "version": "1.5.0", "name": "Java (via SDKMAN!)", "documentationURL": "https://github.com/devcontainers/features/tree/main/src/java", "description": "Installs Java, SDKMAN! (if not installed), and needed dependencies.", @@ -19,11 +19,8 @@ }, "additionalVersions": { "type": "string", - "proposals": [ - "17, 8" - ], "default": "", - "description": "Select or enter additional Java versions to install" + "description": "Enter additional Java versions, separated by commas." }, "jdkDistro": { "type": "string",