Increase default OIDC token expiration - migration from PAT introduces unintended side-effects #1069
JackPGreen
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I've migrated workflows from using
login-actionwith a secret token, to use OIDC - this works well, and is very welcomed.However, this also introduces a non-obvious behaviour:
pull,pushetc)Imagine a workflow that exists to build/push some non-trivial image - e.g. downloads a file, installs some packages etc:
login-actionvia OIDCbuild-push-actionbuilds and pushes image in a single step - except this will fail, because the token will have expired during the build of the imageThe error message will merely say
unauthorized: incorrect username or passwordwhich does not immediately point to a credential expiration issue.Similarly, even with a trivial image in a complex workflow you can run into the same issue:
login-actionvia OIDCbuild-push-actionbuilds and pushes a simple imageI think that for
oidc-action, 5 minutes makes sense, but maybe forlogin-actionit should be higher - or alternatively, the documentation could be improved to stress the (implicit) short-lived nature of the authentication.All reactions