Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/copilot-cli-for-beginners
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: askrinnik/copilot-cli-for-beginners
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 3 files changed
  • 4 contributors

Commits on May 14, 2026

  1. fix(book-app-cs): handle RemoveBook return value in HandleRemove 

    Previously, HandleRemove always printed 'Book removed if it existed'
regardless of whether the title was found. Now checks the bool result
from RemoveBook() and shows a distinct success or not-found message.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    @askrinnik
    askrinnik and Copilot committed May 14, 2026
    Configuration menu
    Copy the full SHA
    95d9cdb View commit details
    Browse the repository at this point in the history

  2. test(book-app-cs): add missing test coverage for FindByAuthor, persis… 

    …tence, and edge cases

- FindByAuthor: exact match, case-insensitive, multiple books by same
  author, and unknown author returning empty
- Persistence: round-trip test verifying data survives a reload via a
  fresh BookCollection instance pointing to the same file
- Edge cases: empty title, empty author, and duplicate titles to
  document current permissive behavior

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    @askrinnik
    askrinnik and Copilot committed May 14, 2026
    Configuration menu
    Copy the full SHA
    a292527 View commit details
    Browse the repository at this point in the history

  3. Initial plan

    Copilot authored May 14, 2026
    Configuration menu
    Copy the full SHA
    d6ab7bb View commit details
    Browse the repository at this point in the history

  4. fix(book-app-cs): return copy from ListBooks and test immutability 

    Agent-Logs-Url: https://github.com/askrinnik/copilot-cli-for-beginners/sessions/7632c3ba-c9f3-445a-a1f6-28ef05710051

Co-authored-by: askrinnik <1359187+askrinnik@users.noreply.github.com>
    @askrinnik
    Copilot and askrinnik authored May 14, 2026
    Configuration menu
    Copy the full SHA
    1915587 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1: Harden ListBooks() against external mutation 

    - Return defensive copy from ListBooks() to prevent external mutation
- Add test verifying mutation of returned list doesn't affect internal state

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
    @askrinnik
    askrinnik and Copilot committed May 14, 2026
    Configuration menu
    Copy the full SHA
    01621c3 View commit details
    Browse the repository at this point in the history
Loading