Skip to content

Commit c0779fa

Browse files
edburnsCopilot
andcommitted
docs: fix ADR relative links in README
The ADRs are at java/docs/adr/, not java/sdk/docs/adr/. Fix the relative links for ADR-006 and ADR-004. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a69f33e-eea6-4b8c-9ef0-8b4d56d53a9c
1 parent a06e77e commit c0779fa

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

java/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ Chain fluent modifiers to set tool options:
308308
- `.defer(ToolDefer)` — control deferred execution (`AUTO`, `NEVER`)
309309
- `.overridesBuiltInTool(boolean)` — shadow built-in tools
310310

311-
For design context and decision rationale, see [ADR-006](sdk/docs/adr/adr-006-tool-definition-inline.md).
311+
For design context and decision rationale, see [ADR-006](docs/adr/adr-006-tool-definition-inline.md).
312312

313313
## Session Store
314314

@@ -432,7 +432,7 @@ The processor uses standard JSR 269 annotation processing APIs for maximum porta
432432
| Local variable with experimental type (including `var` inference) || Move the usage into a declaration the processor can see, or use the compiler flag |
433433
| Cast to experimental type || Use the compiler flag for a whole-compilation opt-in |
434434

435-
In practice, these gaps rarely matter: any meaningful use of an experimental SDK type almost always appears in a field declaration, method signature, or type hierarchy — all of which are caught. A purely inline expression with no declaration footprint (e.g., `session.rpc().experimental.foo().join()`) is the only case that would slip through. See [ADR-004](sdk/docs/adr/adr-004-copilotexperimental.md) for the design rationale.
435+
In practice, these gaps rarely matter: any meaningful use of an experimental SDK type almost always appears in a field declaration, method signature, or type hierarchy — all of which are caught. A purely inline expression with no declaration footprint (e.g., `session.rpc().experimental.foo().join()`) is the only case that would slip through. See [ADR-004](docs/adr/adr-004-copilotexperimental.md) for the design rationale.
436436

437437
### Example
438438

java/sdk/src/main/java/com/github/copilot/ffi/SizeT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* This class uses {@link Native#SIZE_T_SIZE} so JNA marshals the correct width
2121
* on every platform.
2222
*/
23-
final class SizeT extends IntegerType {
23+
public final class SizeT extends IntegerType {
2424

2525
/** Zero-valued instance; required by JNA for return-type instantiation. */
2626
public SizeT() {

0 commit comments

Comments
 (0)