Commit c7c63ab
Fix CI breaks from the CLI 1.0.78-2 schema update
The dependency bump regenerated types but left hand-written code and tests
behind, breaking every language job. Five independent fixes:
- Go: the CLI added a `factory` permission-request kind, so
`PermissionRequestFactory` needed a `RequiresManagedApproval()` impl.
Added it, and registered the new variant in the codegen shim
(`PERMISSION_REQUEST_DEFINITION_NAMES`) so Go/Python/Rust all carry the
`managedApprovalRequired` field consistently.
- .NET: `session.start` gained `githubMcpToolConfig`, so codegen emitted a
`GitHubMcpToolConfig` class colliding with the hand-written one in
`dotnet/src/Types.cs` (15 CS0260/CS0102 errors). Taught the C# generator to
skip nested classes whose names already exist hand-written under
`dotnet/src`, mirroring the existing behavior in the Go generator. The
`[JsonSerializable]` registrations are preserved.
- Java: `SessionEventHandlingTest` calls generated record constructors
positionally; `SessionStartEventData` gained `githubMcpToolConfig` and
`AssistantMessageEventData` gained `chunkIndex`/`chunkCount`. Padded the
three call sites. This also unblocks CodeQL's java-kotlin analysis.
- Rust: `EventLogReadRequest` gained `agent_ids` and `direction`; added them
to the three exhaustive struct literals in `tests/e2e/rpc_event_log.rs`.
- Node.js: the CLI can now answer `session.factory.run`/`resume` before the
run settles, so the e2e test saw `status: "running"`. `SessionFactoryApi`
documents these as resolving with a terminal envelope, so both now route
through a `settleFactoryRun` helper that waits for terminal state when the
initial envelope is non-terminal. Correct under both old and new CLI
behavior.
Validated locally: go build/vet, dotnet build (src + test), mvn test-compile
+ spotless:check + SessionEventHandlingTest (29/29), cargo check --tests +
cargo fmt --check, npm run typecheck/lint, and the full Node unit suite
(363 tests).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 820d6939-ba01-4044-8ee3-c5f5b4d3f4431 parent 545a011 commit c7c63ab
10 files changed
Lines changed: 99 additions & 33 deletions
File tree
- dotnet/src/Generated
- go/rpc
- java/src/test/java/com/github/copilot
- nodejs/src
- python/copilot/generated
- rust
- src/generated
- tests/e2e
- scripts/codegen
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
29 | 35 | | |
30 | 36 | | |
31 | 37 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
857 | 857 | | |
858 | 858 | | |
859 | 859 | | |
860 | | - | |
| 860 | + | |
861 | 861 | | |
862 | 862 | | |
863 | 863 | | |
864 | 864 | | |
865 | 865 | | |
866 | 866 | | |
867 | 867 | | |
868 | | - | |
| 868 | + | |
869 | 869 | | |
870 | 870 | | |
871 | 871 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
461 | 461 | | |
462 | 462 | | |
463 | 463 | | |
464 | | - | |
| 464 | + | |
465 | 465 | | |
466 | 466 | | |
467 | 467 | | |
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
486 | | - | |
| 486 | + | |
487 | 487 | | |
488 | 488 | | |
489 | 489 | | |
| |||
494 | 494 | | |
495 | 495 | | |
496 | 496 | | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
497 | 511 | | |
498 | 512 | | |
499 | 513 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3322 | 3322 | | |
3323 | 3323 | | |
3324 | 3324 | | |
| 3325 | + | |
| 3326 | + | |
| 3327 | + | |
3325 | 3328 | | |
3326 | 3329 | | |
3327 | 3330 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
89 | 91 | | |
90 | 92 | | |
91 | 93 | | |
| 94 | + | |
92 | 95 | | |
93 | 96 | | |
| 97 | + | |
94 | 98 | | |
95 | 99 | | |
96 | 100 | | |
| |||
172 | 176 | | |
173 | 177 | | |
174 | 178 | | |
| 179 | + | |
175 | 180 | | |
176 | 181 | | |
| 182 | + | |
177 | 183 | | |
178 | 184 | | |
179 | 185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
73 | 118 | | |
74 | 119 | | |
75 | 120 | | |
| |||
1456 | 1501 | | |
1457 | 1502 | | |
1458 | 1503 | | |
1459 | | - | |
1460 | | - | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
1461 | 1511 | | |
1462 | 1512 | | |
1463 | 1513 | | |
| |||
1477 | 1527 | | |
1478 | 1528 | | |
1479 | 1529 | | |
| 1530 | + | |
1480 | 1531 | | |
1481 | 1532 | | |
1482 | 1533 | | |
| |||
2629 | 2680 | | |
2630 | 2681 | | |
2631 | 2682 | | |
| 2683 | + | |
2632 | 2684 | | |
2633 | 2685 | | |
2634 | 2686 | | |
| |||
2658 | 2710 | | |
2659 | 2711 | | |
2660 | 2712 | | |
2661 | | - | |
| 2713 | + | |
| 2714 | + | |
| 2715 | + | |
2662 | 2716 | | |
2663 | 2717 | | |
2664 | 2718 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
457 | 457 | | |
458 | 458 | | |
459 | 459 | | |
| 460 | + | |
460 | 461 | | |
461 | 462 | | |
462 | 463 | | |
| |||
0 commit comments