Remove ask/query (#11)

Author: friggeri

README.md

@@ -11,16 +11,23 @@ All SDKs and external facing APIs are in alpha stage and will change in breaking
 **Location:** `./nodejs/`
 
 ```typescript
-import { ask, query, CopilotClient } from "@github/copilot-cli-sdk";
+import { CopilotClient } from "@github/copilot-cli-sdk";
 
-// Simple query
-const result = await ask("What is 2+2?");
-console.log(result.content);
+// Create client and session
+const client = new CopilotClient();
+await client.start();
 
-// Streaming
-for await (const event of query({ prompt: "..." })) {
-    console.log(event);
-}
+const session = await client.createSession({ model: "gpt-5" });
+
+// Listen to events
+session.on((event) => {
+    if (event.type === "assistant.message") {
+        console.log(event.data.content);
+    }
+});
+
+// Send messages
+await session.send({ prompt: "What is 2+2?" });
 ```
 
 **Features:**
@@ -29,7 +36,7 @@ for await (const event of query({ prompt: "..." })) {
 - Real-time event streaming
 - Session history and multi-turn conversations
 - TypeScript type definitions
-- Automatic lifecycle management
+- Full lifecycle control
 
 **Demos:** `./demos/nodejs-demo/`
 
@@ -40,15 +47,23 @@ for await (const event of query({ prompt: "..." })) {
 **Location:** `./python/`
 
 ```python
-from copilot import ask, query, CopilotClient
+from copilot import CopilotClient
+
+# Create client and session
+client = CopilotClient({"use_stdio": True})
+await client.start()
+
+session = await client.create_session({"model": "gpt-5"})
 
-# Simple query
-result = ask("What is 2+2?")
-print(result.content)
+# Listen to events
+def on_event(event):
+    if event.type.value == "assistant.message":
+        print(event.data.content)
 
-# Streaming
-for event in query(prompt="..."):
-    print(event)
+session.on(on_event)
+
+# Send messages
+await session.send({"prompt": "What is 2+2?"})
 ```
 
 **Features:**
@@ -57,7 +72,7 @@ for event in query(prompt="..."):
 - stdio transport
 - Async/await support
 - Type hints (TypedDict)
-- Exact API parity with TypeScript
+- Full lifecycle control
 
 **Demos:** `./demos/python-demo/`
 
@@ -70,58 +85,51 @@ for event in query(prompt="..."):
 ```go
 import copilot "github.com/github/copilot-cli-sdk-go"
 
-// Simple query
-result := copilot.Ask("What is 2+2?", nil)
-fmt.Println(result.Content)
+// Create client and session
+client := copilot.NewClient(&copilot.ClientOptions{UseStdio: true})
+client.Start()
+defer client.Stop()
+
+session, _ := client.CreateSession(&copilot.SessionConfig{Model: "gpt-5"})
+defer session.Destroy()
 
-// Streaming with channels
-for result := range copilot.Query(copilot.QueryOptions{Prompt: "..."}) {
-    if result.Event != nil {
-        fmt.Println(result.Event)
+// Listen to events
+session.On(func(event copilot.SessionEvent) {
+    if event.Type == "assistant.message" {
+        fmt.Println(*event.Data.Content)
     }
-}
+})
+
+// Send messages
+session.Send(copilot.MessageOptions{Prompt: "What is 2+2?"})
 ```
 
 **Features:**
 
 - Goroutine-based JSON-RPC client (zero external dependencies)
 - stdio transport
-- Channel-based streaming
-- Idiomatic Go patterns (defer, goroutines, channels)
-- Exact API parity with TypeScript/Python
+- Channel-based event streaming
+- Idiomatic Go patterns (defer, goroutines)
+- Full lifecycle control
 
 **Demos:** `./demos/go-demo/`
 
 ---
 
 ## Architecture
 
-All SDKs follow the same 3-level API design:
-
-### 1. High-Level Simple API
-
-For quick one-off queries with automatic lifecycle management:
-
-```
-ask(prompt) → result
-```
-
-### 2. High-Level Streaming API
-
-For real-time event streaming:
-
-```
-query(options) → event stream
-```
-
-### 3. Low-Level Advanced API
-
-For full control over lifecycle and sessions:
+All SDKs provide a consistent advanced API for full control over lifecycle and sessions:
 
 ```
 client.start() → session.create() → session.send() → events → session.destroy()
 ```
 
+This gives you:
+- Full control over client and session lifecycle
+- Multiple concurrent sessions
+- Real-time event streaming via callbacks
+- Session history and multi-turn conversations
+
 ## Common Features
 
 All SDKs provide:
@@ -229,9 +237,9 @@ copilot --server --port 8080
 
 | Feature          | TypeScript         | Python            | Go                  |
 | ---------------- | ------------------ | ----------------- | ------------------- |
-| **LOC**          | ~800               | ~1050             | ~930                |
+| **LOC**          | ~600               | ~850              | ~730                |
 | **Concurrency**  | Async/await        | asyncio + threads | Goroutines          |
-| **Streaming**    | Async generators   | Async generators  | Channels            |
+| **Events**       | Callbacks          | Callbacks         | Callbacks           |
 | **JSON-RPC**     | vscode-jsonrpc     | Custom (threads)  | Custom (goroutines) |
 | **Dependencies** | 1 (vscode-jsonrpc) | 0                 | 0                   |
 | **Type Safety**  | TypeScript         | TypedDict         | Structs             |

demos/README.md

@@ -43,9 +43,8 @@ See [nodejs-demo/README.md](nodejs-demo/README.md) for full details.
 
 Complete demo showing:
 
-- High-level `ask()` API
-- Streaming with `query()` generator
-- Real-time ephemeral chunks
+- Client/Session API usage
+- Real-time event streaming
 - Multi-turn conversations with history
 
 **Quick start:**
@@ -54,23 +53,22 @@ Complete demo showing:
 cd python-demo
 PYTHONPATH=../../python:$PYTHONPATH \
 COPILOT_CLI_PATH=../../../dist-cli/index.js \
-python3 query_demo.py
+python3 simple_demo.py
 ```
 
 ### Go (`go-demo/`)
 
 Complete demo showing:
 
-- High-level `Ask()` API
-- Channel-based streaming with `Query()`
+- Client/Session API usage
+- Event-driven callbacks
 - Goroutine-based concurrency
-- Exact API parity with TypeScript/Python
 
 **Quick start:**
 
 ```bash
 cd go-demo
-COPILOT_CLI_PATH=../../../dist-cli/index.js go run query_demo.go
+COPILOT_CLI_PATH=../../../dist-cli/index.js go run simple_demo.go
 ```
 
 ---

demos/go-demo/README.md

@@ -27,8 +27,6 @@ Demo applications showing how to use the Go SDK for GitHub Copilot CLI.
 
 ```bash
 ./run_demo.sh simple_demo.go
-./run_demo.sh ask_demo.go
-./run_demo.sh query_demo.go
 ./run_demo.sh history_demo.go
 ```
 
@@ -45,15 +43,9 @@ export COPILOT_CLI_PATH=../../../dist-cli/index.js
 Then run demos:
 
 ```bash
-# Simple demo - low-level client/session API
+# Simple demo - client/session API
 go run simple_demo.go
 
-# Ask demo - high-level helper for simple queries
-go run ask_demo.go
-
-# Query demo - streaming events as they happen
-go run query_demo.go
-
 # History demo - multi-turn conversation with history
 go run history_demo.go
 ```
@@ -69,18 +61,6 @@ go run history_demo.go
 - Waiting for responses
 - Getting message history
 
-### ask_demo.go
-
-- Using the high-level `Ask()` function
-- Automatic lifecycle management
-- Simple request/response pattern
-
-### query_demo.go
-
-- Using the `Query()` function for streaming
-- Receiving events in real-time
-- Handling ephemeral (streaming) events
-
 ### history_demo.go
 
 - Multi-turn conversations