From 421ff1dbb56aa0e900b56a8955b63a5514cc8a56 Mon Sep 17 00:00:00 2001 From: aoright <102943475+aoright@users.noreply.github.com> Date: Wed, 19 Aug 2026 14:44:54 +0800 Subject: [PATCH] test: add SameSite assertions in TestNewCookieFromOptions Signed-off-by: aoright <102943475+aoright@users.noreply.github.com> --- cookie_test.go | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/cookie_test.go b/cookie_test.go index de530ca..e699433 100644 --- a/cookie_test.go +++ b/cookie_test.go @@ -5,6 +5,7 @@ package sessions import ( + "net/http" "testing" ) @@ -19,15 +20,16 @@ func TestNewCookieFromOptions(t *testing.T) { secure bool httpOnly bool partitioned bool + sameSite http.SameSite }{ - {"", "bar", "/foo/bar", "foo.example.com", 3600, true, true, true}, - {"foo", "", "/foo/bar", "foo.example.com", 3600, true, true, true}, - {"foo", "bar", "", "foo.example.com", 3600, true, true, true}, - {"foo", "bar", "/foo/bar", "", 3600, true, true, true}, - {"foo", "bar", "/foo/bar", "foo.example.com", 0, true, true, true}, - {"foo", "bar", "/foo/bar", "foo.example.com", 3600, false, true, true}, - {"foo", "bar", "/foo/bar", "foo.example.com", 3600, true, false, true}, - {"foo", "bar", "/foo/bar", "foo.example.com", 3600, true, true, false}, + {"", "bar", "/foo/bar", "foo.example.com", 3600, true, true, true, http.SameSiteDefaultMode}, + {"foo", "", "/foo/bar", "foo.example.com", 3600, true, true, true, http.SameSiteLaxMode}, + {"foo", "bar", "", "foo.example.com", 3600, true, true, true, http.SameSiteStrictMode}, + {"foo", "bar", "/foo/bar", "", 3600, true, true, true, http.SameSiteNoneMode}, + {"foo", "bar", "/foo/bar", "foo.example.com", 0, true, true, true, http.SameSiteDefaultMode}, + {"foo", "bar", "/foo/bar", "foo.example.com", 3600, false, true, true, http.SameSiteLaxMode}, + {"foo", "bar", "/foo/bar", "foo.example.com", 3600, true, false, true, http.SameSiteStrictMode}, + {"foo", "bar", "/foo/bar", "foo.example.com", 3600, true, true, false, http.SameSiteNoneMode}, } for i, v := range tests { options := &Options{ @@ -37,6 +39,7 @@ func TestNewCookieFromOptions(t *testing.T) { Secure: v.secure, HttpOnly: v.httpOnly, Partitioned: v.partitioned, + SameSite: v.sameSite, } cookie := newCookieFromOptions(v.name, v.value, options) if cookie.Name != v.name { @@ -63,5 +66,8 @@ func TestNewCookieFromOptions(t *testing.T) { if cookie.Partitioned != v.partitioned { t.Fatalf("%v: bad cookie partitioned: got %v, want %v", i+1, cookie.Partitioned, v.partitioned) } + if cookie.SameSite != v.sameSite { + t.Fatalf("%v: bad cookie sameSite: got %v, want %v", i+1, cookie.SameSite, v.sameSite) + } } }