Skip to content

Commit 66db2da

Browse files
committed
Fix exception on res.end(null) calls
fixes expressjs#75
1 parent 4556a23 commit 66db2da

3 files changed

Lines changed: 16 additions & 1 deletion

File tree

History.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
unreleased
2+
==========
3+
4+
* Fix exception on `res.end(null)` calls
5+
16
1.7.5 / 2014-08-10
27
==================
38

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ function session(options){
193193
var ret;
194194
var sync = true;
195195

196-
if (chunk === undefined) {
196+
if (chunk == null) {
197197
chunk = '';
198198
}
199199

test/session.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,16 @@ describe('session()', function(){
184184
.expect(200, 'Hello, world!', done);
185185
})
186186

187+
it('should handle res.end(null) calls', function (done) {
188+
var server = createServer(null, function (req, res) {
189+
res.end(null)
190+
})
191+
192+
request(server)
193+
.get('/')
194+
.expect(200, '', done)
195+
})
196+
187197
describe('when response ended', function () {
188198
it('should have saved session', function (done) {
189199
var saved = false

0 commit comments

Comments
 (0)