Skip to content

Commit 9020fea

Browse files
committed
Fix parsing original URL
1 parent 7d64dd1 commit 9020fea

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

History.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
unreleased
22
==========
33

4+
* Fix parsing original URL
45
* deps: on-headers@~1.0.0
6+
* deps: parseurl@~1.3.0
57

68
1.7.4 / 2014-08-05
79
==================

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
var cookie = require('cookie');
1414
var debug = require('debug')('express-session');
1515
var deprecate = require('depd')('express-session');
16+
var parseUrl = require('parseurl');
1617
var uid = require('uid-safe').sync
1718
, onHeaders = require('on-headers')
1819
, crc32 = require('buffer-crc32')
19-
, parse = require('url').parse
2020
, signature = require('cookie-signature')
2121

2222
var Session = require('./session/session')
@@ -138,7 +138,7 @@ function session(options){
138138
if (!storeReady) return debug('store is disconnected'), next();
139139

140140
// pathname mismatch
141-
var originalPath = parse(req.originalUrl || req.url).pathname;
141+
var originalPath = parseUrl.original(req).pathname;
142142
if (0 != originalPath.indexOf(cookie.path || '/')) return next();
143143

144144
// backwards compatibility for signed cookies

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"debug": "1.0.4",
1717
"depd": "0.4.4",
1818
"on-headers": "~1.0.0",
19+
"parseurl": "~1.3.0",
1920
"uid-safe": "1.0.1",
2021
"utils-merge": "1.0.0"
2122
},

0 commit comments

Comments
 (0)