File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 11unreleased
22==========
33
4+ * Fix ` TypeError ` when ` req.url ` is an empty string
45 * deps: depd@~ 1.1.1
56 - Remove unnecessary ` Buffer ` loading
67
Original file line number Diff line number Diff line change @@ -191,7 +191,7 @@ function session(options) {
191191 }
192192
193193 // pathname mismatch
194- var originalPath = parseUrl . original ( req ) . pathname ;
194+ var originalPath = parseUrl . original ( req ) . pathname || '/'
195195 if ( originalPath . indexOf ( cookieOptions . path || '/' ) !== 0 ) return next ( ) ;
196196
197197 // ensure a secret is available or bail
Original file line number Diff line number Diff line change @@ -164,6 +164,17 @@ describe('session()', function(){
164164 . expect ( 200 , 'session created' , cb )
165165 } )
166166
167+ it ( 'should handle empty req.url' , function ( done ) {
168+ function setup ( req ) {
169+ req . url = ''
170+ }
171+
172+ request ( createServer ( setup ) )
173+ . get ( '/' )
174+ . expect ( shouldSetCookie ( 'connect.sid' ) )
175+ . expect ( 200 , done )
176+ } )
177+
167178 it ( 'should handle multiple res.end calls' , function ( done ) {
168179 var server = createServer ( null , function ( req , res ) {
169180 res . setHeader ( 'Content-Type' , 'text/plain' )
You can’t perform that action at this time.
0 commit comments