Skip to content

Commit 2d860c0

Browse files
committed
Solves meraki#92 by adding conditionals for each element
1 parent 97f375a commit 2d860c0

2 files changed

Lines changed: 40 additions & 16 deletions

File tree

examples/apiData2CSV_v0.py

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,25 @@ def main(org_id, timespan):
5959
if len(userAgent) > 1:
6060
if "implementation" in userAgent[1]:
6161
userAgentDict = json.loads(urllib.parse.unquote(userAgent[1]))
62-
csvString += userAgentDict['implementation']['name'] + ','
63-
csvString += userAgentDict['implementation']['version'] + ','
64-
csvString += userAgentDict['distro']['name'] + ','
65-
csvString += userAgentDict['distro']['version'] + ','
66-
csvString += userAgentDict['system']['name'] + ','
67-
csvString += userAgentDict['system']['release'] + ','
68-
csvString += userAgentDict['cpu'] + ','
62+
if "implementation" in userAgentDict:
63+
csvString += userAgentDict['implementation']['name'] + ','
64+
csvString += userAgentDict['implementation']['version'] + ','
65+
else:
66+
csvString += ',,'
67+
if "distro" in userAgentDict:
68+
csvString += userAgentDict['distro']['name'] + ','
69+
csvString += userAgentDict['distro']['version'] + ','
70+
else:
71+
csvString += ',,'
72+
if "system" in userAgentDict:
73+
csvString += userAgentDict['system']['name'] + ','
74+
csvString += userAgentDict['system']['release'] + ','
75+
else:
76+
csvString += ',,'
77+
if "cpu" in userAgentDict:
78+
csvString += userAgentDict['cpu'] + ','
79+
else:
80+
csvString += ','
6981
if "be_geo_id" in userAgentDict:
7082
csvString += userAgentDict['be_geo_id'] + ','
7183
else:

examples/apiData2CSV_v1.py

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import argparse
66
import sys
77

8-
import meraki
8+
import meraki_v1
99

1010
import urllib.parse
1111
import platform
@@ -29,7 +29,7 @@
2929

3030
def main(org_id, timespan):
3131
# Instantiate a Meraki dashboard API session
32-
dashboard = meraki.DashboardAPI(
32+
dashboard = meraki_v1.DashboardAPI(
3333
base_url='https://api-mp.meraki.com/api/v1/',
3434
print_console=False,
3535
output_log=False,
@@ -59,13 +59,25 @@ def main(org_id, timespan):
5959
if len(userAgent) > 1:
6060
if "implementation" in userAgent[1]:
6161
userAgentDict = json.loads(urllib.parse.unquote(userAgent[1]))
62-
csvString += userAgentDict['implementation']['name'] + ','
63-
csvString += userAgentDict['implementation']['version'] + ','
64-
csvString += userAgentDict['distro']['name'] + ','
65-
csvString += userAgentDict['distro']['version'] + ','
66-
csvString += userAgentDict['system']['name'] + ','
67-
csvString += userAgentDict['system']['release'] + ','
68-
csvString += userAgentDict['cpu'] + ','
62+
if "implementation" in userAgentDict:
63+
csvString += userAgentDict['implementation']['name'] + ','
64+
csvString += userAgentDict['implementation']['version'] + ','
65+
else:
66+
csvString += ',,'
67+
if "distro" in userAgentDict:
68+
csvString += userAgentDict['distro']['name'] + ','
69+
csvString += userAgentDict['distro']['version'] + ','
70+
else:
71+
csvString += ',,'
72+
if "system" in userAgentDict:
73+
csvString += userAgentDict['system']['name'] + ','
74+
csvString += userAgentDict['system']['release'] + ','
75+
else:
76+
csvString += ',,'
77+
if "cpu" in userAgentDict:
78+
csvString += userAgentDict['cpu'] + ','
79+
else:
80+
csvString += ','
6981
if "be_geo_id" in userAgentDict:
7082
csvString += userAgentDict['be_geo_id'] + ','
7183
else:

0 commit comments

Comments
 (0)