Skip to content

Commit 5b9c2fc

Browse files
author
Shiyue Cheng
committed
Minor fix for APIError exception
1 parent a310d9d commit 5b9c2fc

3 files changed

Lines changed: 11 additions & 8 deletions

File tree

meraki/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
MAXIMUM_RETRIES, OUTPUT_LOG, LOG_PATH, LOG_FILE_PREFIX, PRINT_TO_CONSOLE, SIMULATE_API_CALLS
8686
)
8787

88-
__version__ = '0.90.0'
88+
__version__ = '0.90.1'
8989

9090
class DashboardAPI(object):
9191
"""

meraki/api/devices.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def claimNetworkDevices(self, networkId: str, **kwargs):
5959
}
6060
resource = f'/networks/{networkId}/devices/claim'
6161

62-
body_params = ['serials', 'serial', 'serials']
62+
body_params = ['serials', 'serial']
6363
payload = {k: v for (k, v) in kwargs.items() if k in body_params}
6464

6565
return self._session.post(metadata, resource, payload)

meraki/exceptions.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ def __init__(self, metadata, response):
1414
self.response = response
1515
self.tag = metadata['tags'][0]
1616
self.operation = metadata['operation']
17-
self.status = self.response.status_code if self.response else None
18-
self.reason = self.response.reason if self.response else None
17+
self.status = self.response.status_code if self.response.status_code else None
18+
self.reason = self.response.reason if self.response.reason else None
1919
try:
20-
self.message = self.response.json() if self.response else None
20+
self.message = self.response.json() if self.response.json() else None
2121
except ValueError:
2222
self.message = self.response.text[:100]
2323
super(APIError, self).__init__(f'{self.tag}, {self.operation} - {self.status} {self.reason}, {self.message}')
@@ -31,9 +31,12 @@ def __init__(self, metadata, response, message):
3131
self.response = response
3232
self.tag = metadata['tags'][0]
3333
self.operation = metadata['operation']
34-
self.status = self.response.status if self.response else None
35-
self.reason = self.response.reason if self.response else None
36-
self.message = message[:100]
34+
self.status = self.response.status if self.response.status else None
35+
self.reason = self.response.reason if self.response.reason else None
36+
try:
37+
self.message = self.response.json() if self.response.json() else None
38+
except ValueError:
39+
self.message = self.response.text[:100]
3740
super().__init__(
3841
f'{self.tag}, {self.operation} - {self.status} {self.reason}, {self.message}'
3942
)

0 commit comments

Comments
 (0)