Skip to content

Commit 8646747

Browse files
author
Shiyue Cheng
authored
Merge pull request meraki#90 from coreGreenberet/AsyncApiError
fixed wrong "message" handling in AsyncAPIError
2 parents bc21b68 + 02df0c5 commit 8646747

2 files changed

Lines changed: 8 additions & 12 deletions

File tree

meraki_v0/exceptions.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ def __init__(self, metadata, response, message):
3131
self.response = response
3232
self.tag = metadata['tags'][0]
3333
self.operation = metadata['operation']
34-
self.status = self.response.status if self.response is not None and self.response.status else None
35-
self.reason = self.response.reason if self.response is not None and self.response.reason else None
36-
try:
37-
self.message = self.response.json() if self.response is not None and self.response.json() else None
38-
except ValueError:
39-
self.message = self.response.text[:100]
34+
self.status = response.status if response is not None and response.status else None
35+
self.reason = response.reason if response is not None and response.reason else None
36+
self.message = message
37+
4038
super().__init__(
4139
f'{self.tag}, {self.operation} - {self.status} {self.reason}, {self.message}'
4240
)

meraki_v1/exceptions.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ def __init__(self, metadata, response, message):
3131
self.response = response
3232
self.tag = metadata['tags'][0]
3333
self.operation = metadata['operation']
34-
self.status = self.response.status if self.response is not None and self.response.status else None
35-
self.reason = self.response.reason if self.response is not None and self.response.reason else None
36-
try:
37-
self.message = self.response.json() if self.response is not None and self.response.json() else None
38-
except ValueError:
39-
self.message = self.response.text[:100]
34+
self.status = response.status if response is not None and response.status else None
35+
self.reason = response.reason if response is not None and response.reason else None
36+
self.message = message
37+
4038
super().__init__(
4139
f'{self.tag}, {self.operation} - {self.status} {self.reason}, {self.message}'
4240
)

0 commit comments

Comments
 (0)