Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opensearch-project/search-processor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: msfroh/search-processor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jul 25, 2023

  1. Reject Personalize processor in ad hoc pipeline 

    If we create a search pipeline as part of a search request, each
processor gets created as part of the search request. Since the
Amazon Personalize ranking processor creates a client (with a connection
pool and credential provider), this could get expensive if someone sends
a flurry of search requests with inline (ad hoc) pipelines.

Also, when a pipeline is created, we create each processor as a way of
validating the configuration. At that point, we don't need to initialize
the Personalize client, since that processor will just get
garbage-collected.

Signed-off-by: Michael Froh <froh@amazon.com>
    @msfroh
    msfroh committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e5be5d5 View commit details
    Browse the repository at this point in the history
Loading