Repository navigation
Replies: 5 comments 1 reply
|
I had codex do an implementation of this and it took about 20m, but I'm not a front end dev, so I figured it would be easier to post an issue then asking for a code review. If you want, I can post the changes as a PR. |
|
This & more is already implemented in #4849 It will be merged to nightly soon |
|
@Bil0000 the changes did not implement the ability to review a single local commit. |
|
+1. Agents often produce a stack of commits, and reading them one at a time is the natural way to review that work. An idea on top of this: once the Commits picker exists, each commit could get a short AI-generated title and summary, such as "Update X so it does Y", with the files and folders it changed listed beneath. Many agent-written commit subjects are vague, and a one-line summary makes it easy to pick the commit you want. A small or cheap model is enough for this, ideally the guide model already configured for review guides (#18124). The same per-commit grouping could also drive a "group by commit" mode for review guides in the PR sidebar. I've added more detail in #16824. |
Uh oh!
There was an error while loading. Please reload this page.
Before submitting
Area
apps/web
Problem or use case
The Diff pane currently lets me inspect Working tree, Branch changes, Latest turn, or individual Turns.
Branch changes is cumulative, while Turns are based on T3 checkpoints. Neither option lets me review the actual Git commits on the current branch one at a time.
When an agent creates several commits, I want to inspect the exact diff introduced by each commit without leaving T3. Today I have to use
git show, GitHub, or another Git client, losing the integrated Diff pane workflow.Proposed solution
Add a “Commits” submenu to the existing diff-source picker, parallel to the existing “Turns” submenu. This is similar to the design in Codex.
The submenu should list the commits included in the current Branch changes range, showing at least each commit’s subject and age. Selecting a commit should display only the changes introduced by that commit — its parent-to-commit diff — using the existing Diff pane renderer and controls.
The other sources, such as Working tree, Branch changes, Latest turn, and Turns, should remain available as they are today.
Why this matters
Agents frequently produce a stack of commits, and reviewing only the cumulative branch diff can hide whether changes were divided into coherent commits.
A commit-by-commit view would make it easier to review history before opening a PR, understand why a change was introduced, and catch commits that contain unrelated or incomplete work. Codex has a similar view, and it is especially useful when reviewing agent-generated changes.
Smallest useful scope
List the commits in the existing Branch changes range and allow selecting one to view its parent-to-commit diff in the web Diff pane and desktop wrapper.
It should fetch the selected commit’s patch on demand rather than loading every commit’s patch up front.
Alternatives considered
The only alternative is to use an external tool.
Risks or tradeoffs
git showbehavior.Examples or references
Codex provides a commit-by-commit diff view with a commit selector.
Related but not duplicate T3 work:
feat: multi-provider pull requests page with in-app reviews #4849
feat(vcs): add actionable Version Control to web and mobile #3177
feat(web): add a since-fork diff scope #5193
Contribution
All reactions