Git - Bug Fix: Feature fails with "ppa:false" for "buster" & "bullseye" (devcontainers#340)

Author: samruddhikhandale

src/git/devcontainer-feature.json

@@ -1,6 +1,6 @@
 {
     "id": "git",
-    "version": "1.1.1",
+    "version": "1.1.2",
     "name": "Git (from source)",
     "documentationURL": "https://github.com/devcontainers/features/tree/main/src/git",
     "description": "Install an up-to-date version of Git, built from source as needed. Useful for when you want the latest and greatest features. Auto-detects latest stable version and installs needed dependencies.",

src/git/install.sh

@@ -149,9 +149,9 @@ fi
 
 check_packages libpcre2-dev
 
-if [ "${VERSION_CODENAME}" = "focal" ]; then
+if [ "${VERSION_CODENAME}" = "focal" ] || [ "${VERSION_CODENAME}" = "bullseye" ]; then
     check_packages libpcre2-posix2
-elif [ "${VERSION_CODENAME}" = "bionic" ]; then
+elif [ "${VERSION_CODENAME}" = "bionic" ] || [ "${VERSION_CODENAME}" = "buster" ]; then
     check_packages libpcre2-posix0
 else
     check_packages libpcre2-posix3

test/git/install_git_from_src_bullseye.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+check "version" git  --version
+check "gettext" dpkg-query -l gettext
+
+cd /tmp && git clone https://github.com/devcontainers/feature-starter.git
+cd feature-starter
+check "perl" bash -c "git -c grep.patternType=perl grep -q 'a.+b'"
+
+# Report result
+reportResults

test/git/install_git_from_src_buster.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+set -e
+
+# Optional: Import test library
+source dev-container-features-test-lib
+
+check "version" git  --version
+check "gettext" dpkg-query -l gettext
+
+cd /tmp && git clone https://github.com/devcontainers/feature-starter.git
+cd feature-starter
+check "perl" bash -c "git -c grep.patternType=perl grep -q 'a.+b'"
+
+# Report result
+reportResults

test/git/scenarios.json

@@ -25,5 +25,23 @@
                 "ppa": "false"
             }
         }
+    },
+    "install_git_from_src_bullseye": {
+        "image": "debian:bullseye",
+        "features": {
+            "git": {
+                "version": "latest",
+                "ppa": "false"
+            }
+        }
+    },
+    "install_git_from_src_buster": {
+        "image": "debian:buster",
+        "features": {
+            "git": {
+                "version": "latest",
+                "ppa": "false"
+            }
+        }
     }
 }