Adding logs to surface AZ-CLI and powershell errors - #171
Merged
Balaga Gayatri (BALAGA-GAYATRI) merged 31 commits intoNov 12, 2021
Conversation
Balaga Gayatri (BALAGA-GAYATRI)
commented
Nov 11, 2021
Balaga Gayatri (BALAGA-GAYATRI)
commented
Contributor
Balaga Gayatri (BALAGA-GAYATRI)
requested review from
Usha N (N-Usha),
Kanika Pasrija (kanika1894) and
Kanchan Verma (kaverma)
November 11, 2021 12:20
| catch (error) { | ||
| if (!isAzCLISuccess) { | ||
| core.error("Az CLI Login failed. Please check the credentials. For more information refer https://aka.ms/create-secrets-for-GitHub-workflows"); | ||
| core.setFailed("Az CLI Login failed. Please check the credentials. For more information refer https://aka.ms/create-secrets-for-GitHub-workflows"); |
Contributor
There was a problem hiding this comment.
what's the difference between .error and .setFailed
Contributor
Author
There was a problem hiding this comment.
execution stops here if setFailed otherwise it continues.
Kanchan Verma (kaverma)
approved these changes
Nov 12, 2021
| failOnStdErr: true, | ||
| listeners: { | ||
| stderr: (data: Buffer) => { | ||
| let error = data.toString().replace('ERROR',''); |
Contributor
There was a problem hiding this comment.
we want to replace only the starting ERROR substring and not all ERROR mentions right?
Contributor
Author
There was a problem hiding this comment.
Made small change. It replaces only first occurrence in the beginning of the message now.
| listeners: { | ||
| stderr: (data: Buffer) => { | ||
| let error = data.toString().replace('ERROR',''); | ||
| if(error && error.trim().length !== 0) |
Contributor
There was a problem hiding this comment.
nit: formatting - space after if
Contributor
Author
There was a problem hiding this comment.
done
Balaga Gayatri (BALAGA-GAYATRI)
added a commit
that referenced
this pull request
Nov 15, 2021
* cherry pick changes * added audience field option in input params * added js * removed extra spaces * Adding logs to surface AZ-CLI and powershell errors (#171) * removing token logs
Balaga Gayatri (BALAGA-GAYATRI)
added a commit
that referenced
this pull request
Nov 15, 2021
* cherry pick changes * added audience field option in input params * added js * removed extra spaces * Adding logs to surface AZ-CLI and powershell errors (#171) * removing token logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.