Skip to content

OIDC support for sovereign clouds - #258

Closed
Nate Arnold (arnoldna) wants to merge 3 commits into
Azure:masterfrom
arnoldna:master
Closed

OIDC support for sovereign clouds#258
Nate Arnold (arnoldna) wants to merge 3 commits into
Azure:masterfrom
arnoldna:master

Conversation

@arnoldna

Copy link
Copy Markdown

Added OIDC support for AzureUSGovernment and AzureChinaCloud

ISSUE #257- #257

@arnoldna
Nate Arnold (arnoldna) temporarily deployed to Automation test October 27, 2022 00:23 Inactive
@BALAGA-GAYATRI

Copy link
Copy Markdown
Contributor

Nate Arnold (@arnoldna) Thanks for the PR. Can you add more details on the tests that were done for this PR?

@arnoldna

Copy link
Copy Markdown
Author

I have access to an AzureUSGovernment subscription and tested connectivity utilizing the following yaml:

`name: Run Azure Login with OpenID Connect
on: [push]

permissions:
id-token: write
contents: read

jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:
- name: 'Az CLI login'
uses: azure/login@v1
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
environment: 'AzureUSGovernment'

- name: 'Run Azure CLI commands'
  run: |
      az account show
      az group list
      pwd`

If there are other tests you would like to run then let me know.

@jpmicrosoft

Copy link
Copy Markdown

Balaga Gayatri (@BALAGA-GAYATRI) Any updates on this PR?

@github-actions

github-actions Bot commented Dec 5, 2022

Copy link
Copy Markdown

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions Bot added the idle Inactive for 14 days label Dec 5, 2022

@jpmicrosoft JP (jpmicrosoft) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@BALAGA-GAYATRI

Copy link
Copy Markdown
Contributor

We are following up on the same. Will get back with the info.

@arnoldna

Copy link
Copy Markdown
Author

Balaga Gayatri (@BALAGA-GAYATRI) - Can we get an update on when this PR will be approved? Thanks

@github-actions github-actions Bot removed the idle Inactive for 14 days label Mar 9, 2023
@github-actions

Copy link
Copy Markdown

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions Bot added the idle Inactive for 14 days label Mar 23, 2023
@some-natalie

Copy link
Copy Markdown

friendly bump on this ❤️

@github-actions github-actions Bot removed the idle Inactive for 14 days label May 3, 2023
@devopsjesus

Copy link
Copy Markdown

Looks like the linting is failing on README - can someone please fix this and merge? PR has been open for months

@MoChilia

Copy link
Copy Markdown
Member

Closing this pr, the feature is done in #321.

Comment thread src/main.ts
Comment on lines +74 to +87
switch(environment){
case 'azurecloud':
resourceManagerEndpointUrl = "https://management.azure.com/";
break;
case 'azureusgovernment':
resourceManagerEndpointUrl = "https://management.usgovcloudapi.net/";
break;
case 'azurechinacloud':
resourceManagerEndpointUrl = "https://management.chinacloudapi.cn/";
break;
default:
resourceManagerEndpointUrl = "https://management.azure.com/";
break;
}

@jiasli Jiashuo Li (jiasli) May 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resourceManagerEndpointUrl is in the output of az ad sp create-for-rbac --sdk-auth and az cloud list/show, so it shouldn't be hard-coded.

> az ad sp create-for-rbac --sdk-auth
{
  "clientId": "...",
  "clientSecret": "...",
  "subscriptionId": "...",
  "tenantId": "...",
  "activeDirectoryEndpointUrl": "https://login.microsoftonline.com",
  "resourceManagerEndpointUrl": "https://management.azure.com/",
  "activeDirectoryGraphResourceId": "https://graph.windows.net/",
  "sqlManagementEndpointUrl": "https://management.core.windows.net:8443/",
  "galleryEndpointUrl": "https://gallery.azure.com/",
  "managementEndpointUrl": "https://management.core.windows.net/"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants