Skip to content

Update azure/CLI@v1 to azure/cli@v2 and azure/powershell@v1 to azure/powershell@v2 #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yan Xu (YanaXu) merged 2 commits into from
Apr 26, 2024
+34 −37
Merged

Update azure/CLI@v1 to azure/cli@v2 and azure/powershell@v1 to azure/powershell@v2 #438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5765d3e
patch
jiasli Apr 25, 2024
f4560be
fix indentation
jiasli Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 34 additions & 37 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@ name: Run Azure Login with OIDC
on: [push]

permissions:
id-token: write
contents: read
jobs:
id-token: write
contents: read
Comment on lines +186 to +187

@jiasli Jiashuo Li (jiasli) Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation according to https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers#adding-permissions-settings

jobs:

@jiasli Jiashuo Li (jiasli) Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespaces are removed for consistency.

build-and-deploy:
runs-on: ubuntu-latest
steps:
Expand All @@ -195,9 +195,9 @@ jobs:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
Expand All @@ -213,9 +213,9 @@ name: Run Azure Login with OIDC
on: [push]

permissions:
id-token: write
contents: read
jobs:
id-token: write
contents: read
jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:
Expand All @@ -226,16 +226,16 @@ jobs:
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
enable-AzPSSession: true

- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
az account show

- name: Azure PowerShell script
uses: azure/powershell@v1
uses: azure/powershell@v2
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -281,18 +281,17 @@ jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:

- uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}

- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
az account show

```

- **The workflow sample to run both Azure CLI and Azure PowerShell**
Expand All @@ -309,21 +308,21 @@ jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:

- uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
enable-AzPSSession: true

- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
az account show

- name: Azure PowerShell script
uses: azure/powershell@v1
uses: azure/powershell@v2
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -372,29 +371,29 @@ Now you can try the workflow to login with system-assigned managed identity.
name: Run Azure Login with System-assigned Managed Identity
on: [push]

jobs:
jobs:
build-and-deploy:
runs-on: self-hosted
steps:
- name: Azure login
uses: azure/login@v2
with:
auth-type: IDENTITY
auth-type: IDENTITY
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
enable-AzPSSession: true

# Azure CLI Action only supports linux self-hosted runners for now.
# If you want to execute the Azure CLI script on a windows self-hosted runner, you can execute it directly in `run`.
# Azure CLI Action only supports linux self-hosted runners for now.
# If you want to execute the Azure CLI script on a windows self-hosted runner, you can execute it directly in `run`.
- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
az account show

- name: Azure PowerShell script
uses: azure/powershell@v1
uses: azure/powershell@v2
with:
azPSVersion: "latest"
inlineScript: |
Expand Down Expand Up @@ -438,30 +437,30 @@ Now you can try the workflow to login with user-assigned managed identity.
name: Run Azure Login with User-assigned Managed Identity
on: [push]

jobs:
jobs:
build-and-deploy:
runs-on: self-hosted
steps:
- name: Azure login
uses: azure/login@v2
with:
auth-type: IDENTITY
client-id: ${{ secrets.AZURE_CLIENT_ID }}
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
enable-AzPSSession: true

# Azure CLI Action only supports linux self-hosted runners for now.
# If you want to execute the Azure CLI script on a windows self-hosted runner, you can execute it directly in `run`.
# Azure CLI Action only supports linux self-hosted runners for now.
# If you want to execute the Azure CLI script on a windows self-hosted runner, you can execute it directly in `run`.
- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
az account show

- name: Azure PowerShell script
uses: azure/powershell@v1
uses: azure/powershell@v2
with:
azPSVersion: "latest"
inlineScript: |
Expand All @@ -482,13 +481,12 @@ jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:

- uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
environment: 'AzureUSGovernment'
enable-AzPSSession: true

```

### Login to Azure Stack Hub
Expand All @@ -505,13 +503,12 @@ jobs:
build-and-deploy:
runs-on: ubuntu-latest
steps:

- uses: azure/login@v2
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
environment: 'AzureStack'
enable-AzPSSession: true

```

Refer to the [Azure Stack Hub Login Action Tutorial](https://learn.microsoft.com/azure-stack/user/ci-cd-github-action-login-cli) for more detailed instructions.
Expand Down Expand Up @@ -542,14 +539,14 @@ jobs:
enable-AzPSSession: true

- name: Azure CLI script
uses: azure/CLI@v1
uses: azure/cli@v2
with:
azcliversion: latest
inlineScript: |
az account show

- name: Run Azure PowerShell
uses: azure/powershell@v1
uses: azure/powershell@v2
with:
azPSVersion: "latest"
inlineScript: |
Expand Down