GitHub Actions Beta Preview for deploying to Azure Stack Hub - #93
Merged
Conversation
* login action for azurestack * test update for azurestack * review changes * review changes v2 * review changes v3
Update README.md
* update build files * add node_modules
* added support for Azure Gov cloud * changes to Azure cloud * az gov cloud changes * changes as per PR comment * chnages to include enum and valdiation * changes to include validation * changes * deleted Enums.js * changes to constant file * added library of Consts.js * changes from arary to set * changes to environment input
garvitarai
reviewed
Dec 28, 2020
garvitarai
left a comment
garvitarai
left a comment
Contributor
There was a problem hiding this comment.
The title should probably be updated from " GitHub Actions Beta Preview for deploying to Azure Stack Hub"
Arjun Gupta (arjgupta)
changed the title
Ashish Ranjan (asranja)
approved these changes
Dec 30, 2020
|
|
||
| console.log(`Unregistering cloud: "${environment}" first if it exists`); | ||
| try { | ||
| await executeAzCliCommand(`cloud set -n AzureCloud`, true); |
Contributor
Author
There was a problem hiding this comment.
why is it needed to set the current cloud to 'AzureCloud' in order for the unregister to work ?
Arjun Gupta (arjgupta)
added a commit
that referenced
this pull request
Dec 31, 2020
GitHub Actions Beta Preview for deploying to Azure Stack Hub
Arjun Gupta (arjgupta)
added a commit
that referenced
this pull request
Dec 31, 2020
…upport-release Merge pull request #93 from Azure/azuresovereigncloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.