Superuser addOptions#498
Merged
Merged
Conversation
added same parameters to addSuperusers that already exists in addUser method (-e, -p, -r, -u) updated tests in UsersShellTest to test addSuperuser with and without parameters. addSuperuser and addUser are now more or less a repetition and should be rewritten to keep it DRY. But I'll save that work for a rainy day.
steinkel
reviewed
Feb 17, 2017
| $user = [ | ||
| 'username' => 'yeliparra', | ||
| 'password' => '123', | ||
| 'email' => 'yeli.parra@gmail.com', |
Member
There was a problem hiding this comment.
please use @example.com for domain names in tests
Switched to example.com domains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added same parameters to addSuperusers that already exists in addUser
method (-e, -p, -r, -u)
updated tests in UsersShellTest to test addSuperuser with and without
parameters.
addSuperuser and addUser are now more or less a repetition and should
be rewritten to keep it DRY. But I'll save that work for a rainy day.