Patch of bug #544 Changed all setError calls back to error calls#545
Merged
Merged
Conversation
This fails on one test. UsersShellTest::testResetAllPasswordsNoPassingParams This test expects a call to the setError method I guess there was a plan to implement the setError method.
Member
|
good catch, I'll merge it and fix the test in develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch to get UserShell back in working state.
This fails on one test.
UsersShellTest::testResetAllPasswordsNoPassingParams
This test expects a call to the setError method
I guess there was a plan to implement the setError method.