Skip to content

Replace deprecated methods for CakePHP 3.6#672

Merged
steinkel merged 9 commits into
CakeDC:developfrom
jtraulle:3.next
Apr 18, 2018
Merged

Replace deprecated methods for CakePHP 3.6#672
steinkel merged 9 commits into
CakeDC:developfrom
jtraulle:3.next

Conversation

@jtraulle

@jtraulle jtraulle commented Apr 1, 2018

Copy link
Copy Markdown
Contributor

All deprecated methods/properties has been replaced by the new ones.
Test has been modified accordingly.

@codecov-io

codecov-io commented Apr 1, 2018

Copy link
Copy Markdown

Codecov Report

Merging #672 into develop will not change coverage.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #672   +/-   ##
==========================================
  Coverage      80.37%   80.37%           
  Complexity       543      543           
==========================================
  Files             52       52           
  Lines           1692     1692           
==========================================
  Hits            1360     1360           
  Misses           332      332
Impacted Files Coverage Δ Complexity Δ
src/Controller/Traits/LoginTrait.php 50.57% <ø> (ø) 51 <0> (ø) ⬇️
src/Controller/SocialAccountsController.php 77.77% <ø> (ø) 11 <0> (ø) ⬇️
src/Controller/Traits/SocialTrait.php 100% <ø> (ø) 4 <0> (ø) ⬇️
src/Controller/Traits/RegisterTrait.php 96.72% <ø> (ø) 16 <0> (ø) ⬇️
src/Controller/Traits/UserValidationTrait.php 84.44% <ø> (ø) 14 <0> (ø) ⬇️
src/Controller/Traits/SimpleCrudTrait.php 96.42% <100%> (ø) 10 <0> (ø) ⬇️
src/Auth/SocialAuthenticate.php 54.76% <100%> (ø) 77 <0> (ø) ⬇️
src/Controller/Component/UsersAuthComponent.php 80% <100%> (ø) 27 <0> (ø) ⬇️
src/Mailer/UsersMailer.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/Controller/Component/RememberMeComponent.php 86.66% <100%> (ø) 18 <0> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4364ecf...f286dfb. Read the comment docs.

@steinkel

Copy link
Copy Markdown
Member

Impressive!
We'll take a look ASAP, thank you!!

@jtraulle

Copy link
Copy Markdown
Contributor Author

Happy to help 🙂

@jtraulle

Copy link
Copy Markdown
Contributor Author

All Friends Of Cake cake-36 branches has been merged 🎉
Have you had a chance to get a quick look at this MR @steinkel ? Last thing to be tagged/released before I can upgrade my app to 3.6 😉
No pressure however 😘

@saeideng

saeideng commented Apr 15, 2018

Copy link
Copy Markdown

you should update your branch before creating PR
or for now, re-base on the develop

Merge upstream develop branch into 3.next
@jtraulle

jtraulle commented Apr 15, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for pointing that out @saeideng, I have merged the extra commits from develop branch into my branch 😉

@medero

medero commented Apr 16, 2018

Copy link
Copy Markdown

Nice work! Also looking to use in a 3.6 upgrade so can't wait!

jtraulle and others added 2 commits April 16, 2018 15:54
Fix typo, in previous code but detected just now :P
@steinkel
steinkel merged commit 16d18a1 into CakeDC:develop Apr 18, 2018
@jtraulle
jtraulle deleted the 3.next branch April 20, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants