Save user in temp session for Two factor authentication - #698
Closed
rochamarcelo wants to merge 4 commits into
Closed
Save user in temp session for Two factor authentication#698rochamarcelo wants to merge 4 commits into
rochamarcelo wants to merge 4 commits into
Conversation
ndm2
reviewed
Jun 8, 2018
| } | ||
| $temporarySession = $this->request->getSession()->read('temporarySession'); | ||
|
|
||
| if (array_key_exists('secret', $temporarySession)) { |
There was a problem hiding this comment.
It probably won't interfer with authentication anymore, but this will still trigger an error in case temporarySession isn't set, or if it contains a non-array for whatever reason.
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
============================================
- Coverage 80.37% 80.33% -0.05%
Complexity 543 543
============================================
Files 52 52
Lines 1692 1693 +1
============================================
Hits 1360 1360
- Misses 332 333 +1
Continue to review full report at Codecov.
|
ndm2
reviewed
Jun 8, 2018
| } | ||
|
|
||
| $temporarySession = $this->request->getSession()->read('temporarySession'); | ||
| if (empty($temporarySession)) { |
There was a problem hiding this comment.
A non-array value could still slip through ;)
Member
|
closed by #699 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.