Change the old syntax of $this->request->session() to `$this->reque… - #712
Closed
Lartak wants to merge 21 commits into
Closed
Change the old syntax of $this->request->session() to `$this->reque…#712Lartak wants to merge 21 commits into
$this->request->session() to `$this->reque…#712Lartak wants to merge 21 commits into
Conversation
Release v7.0.0
fixes CakeDC#570 thanks to @makamo for reporting
CakeDC/Users.RememberMe -> CakeDC/Auth.RememberMe
…wo-factor-auth Rochamarcelo issue/google two factor auth
This patch ensures that a new secret is only generated in case the user record doesn't already has a secret set.
Ensures that the user data is persisted in the storage configured for the Auth component, and that the `secret_verified` flag is set properly.
…regeneration Fix two factor auth only working on the second try.
…st->getSession()`. The new syntax.
Codecov Report
@@ Coverage Diff @@
## develop #712 +/- ##
=============================================
+ Coverage 70.57% 80.04% +9.47%
+ Complexity 555 543 -12
=============================================
Files 53 52 -1
Lines 1706 1694 -12
=============================================
+ Hits 1204 1356 +152
+ Misses 502 338 -164
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st->getSession()`.
The new syntax.