Skip to content

Feature/u2f#757

Merged
rochamarcelo merged 18 commits into
CakeDC:8.nextfrom
rochamarcelo:feature/u2f
Feb 11, 2019
Merged

Feature/u2f#757
rochamarcelo merged 18 commits into
CakeDC:8.nextfrom
rochamarcelo:feature/u2f

Conversation

@rochamarcelo

Copy link
Copy Markdown
Collaborator

No description provided.

@rochamarcelo
rochamarcelo requested a review from steinkel February 8, 2019 12:19
Comment thread src/Template/Users/u2f_register.ctp Outdated
@steinkel

steinkel commented Feb 8, 2019

Copy link
Copy Markdown
Member

looks good, please merge when build passed

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #757 into 8.next will increase coverage by 0.42%.
The diff coverage is 88.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             8.next     #757      +/-   ##
============================================
+ Coverage     81.44%   81.87%   +0.42%     
- Complexity      569      601      +32     
============================================
  Files            56       60       +4     
  Lines          1741     1859     +118     
============================================
+ Hits           1418     1522     +104     
- Misses          323      337      +14
Impacted Files Coverage Δ Complexity Δ
src/Controller/Component/UsersAuthComponent.php 80.59% <ø> (ø) 28 <0> (ø) ⬇️
src/Controller/UsersController.php 0% <0%> (ø) 2 <2> (?)
src/Auth/U2fAuthenticationCheckerFactory.php 100% <100%> (ø) 2 <2> (?)
src/Model/Table/UsersTable.php 100% <100%> (ø) 8 <1> (+1) ⬆️
src/Model/Entity/User.php 97.29% <100%> (+0.42%) 16 <3> (+3) ⬆️
src/Auth/DefaultU2fAuthenticationChecker.php 100% <100%> (ø) 3 <3> (?)
src/Controller/Traits/LoginTrait.php 62.17% <44.44%> (-1.27%) 55 <6> (+2)
src/Controller/Traits/U2fTrait.php 96.51% <96.51%> (ø) 19 <19> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e94ca3...af69425. Read the comment docs.

@rochamarcelo
rochamarcelo merged commit 0b52456 into CakeDC:8.next Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants