Honor config option for username field#781
Merged
Merged
Conversation
_findUser() should always be called to return an array, otherwise auth will fail
Codecov Report
@@ Coverage Diff @@
## 8.next #781 +/- ##
===========================================
- Coverage 81.62% 81.6% -0.02%
+ Complexity 606 605 -1
===========================================
Files 61 61
Lines 1872 1870 -2
===========================================
- Hits 1528 1526 -2
Misses 344 344
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using the
usernamefield, this checks the config.Also, if the
$this->_findUser()method is not called, the value returned will be a user entity instead of an array, causing the authentication to fail.