Before social login redirect#792
Merged
steinkel merged 10 commits intoMay 29, 2019
Merged
Conversation
Added event before social redirect
Collaborator
Author
|
Related to #782 |
…in-redirect # Conflicts: # composer.json
Codecov Report
@@ Coverage Diff @@
## 8.next #792 +/- ##
============================================
- Coverage 81.6% 81.59% -0.01%
- Complexity 605 606 +1
============================================
Files 61 61
Lines 1870 1875 +5
============================================
+ Hits 1526 1530 +4
- Misses 344 345 +1
Continue to review full report at Codecov.
|
steinkel
approved these changes
May 28, 2019
steinkel
left a comment
steinkel
left a comment
Member
There was a problem hiding this comment.
It looks good, a couple comments mostly questions
| $location = $provider->getAuthorizationUrl($authParams); | ||
|
|
||
| $response = $response->withLocation($provider->getAuthorizationUrl($authParams)); | ||
| $this->dispatchEvent(UsersAuthComponent::EVENT_BEFORE_SOCIAL_LOGIN_REDIRECT, compact('location', 'request')); |
Member
There was a problem hiding this comment.
event could return another location for example?
| $this->request->getSession()->write('temporary_credentials', $temporaryCredentials); | ||
| } | ||
| $authUrl = $provider->getAuthorizationUrl($temporaryCredentials); | ||
| $this->dispatchEvent(UsersAuthComponent::EVENT_BEFORE_SOCIAL_LOGIN_REDIRECT, [ |
Member
There was a problem hiding this comment.
what does the event could return?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.