Repository navigation
WCV example - #5
Merged
Merged
Conversation
Merged
RyanGlScott
approved these changes
Nov 15, 2021
Collaborator
There was a problem hiding this comment.
My apologies for letting this sit for a while. I've merged in the latest changes from main, since they overlap with this PR somewhat. I also pushed a separate commit which includes a workaround for Copilot-Language/copilot#263 so that the WCV example verifies.
The main thrust of the PR looks great. Are there still improvements to be made regarding the error message reporting, or should we just land this?
Contributor
Author
|
We definitely should improve the error reporting, but I don't know it should keep us from landing this. Let's open a ticket. |
This is enough to begin serious verification work on the WCV example. It doesn't currently verify, however, because the generated code for the example is using the integer `abs` function when the double-valued `fabs` is intended instead.
RyanGlScott
force-pushed
the
wcv-example
branch
from
November 15, 2021 19:19
cfd785c to
cc8c213
Compare
RyanGlScott
marked this pull request as ready for review
November 15, 2021 19:23
Collaborator
|
I've opened #12 to continue the effort to improve error-message reporting. |
RyanGlScott
added a commit
that referenced
this pull request
Jan 24, 2022
Currently, there is only one verifier-specific option, the `Verbosity`. However, implementing a fix for #5 will require yet another option, so this patch will make it simpler to add another option when the time comes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in some submodule updates and start incorporating floating-point support.
This PR adds a new example based on the well-clear violation code from the copilot examples directory. It doesn't currently verify because of Copilot-Language/copilot#263
Independent of that, however, we have an opportunity for improvement here, as the output of the tool currently is: