Skip to content

Release 3.18 #487

Closed
Closed

Description

@ivanperez-keera

Description

Version 3.18 of Copilot is ready and should be closed and published on Hackage.

Type

  • Management: release and publication.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

Not applicable (not a bug).

Expected result

  • Cabal files indicate new version number, constraints are adjusted as needed, commit is tagged with version number, and packages are published on hackage.

Desired result

  • Cabal files indicate new version number, constraints are adjusted as needed, commit is tagged with version number, and packages are published on hackage.

Proposed solution

  • Cabal files indicate new version number, constraints are adjusted as needed, commit is tagged with version number, and packages are published on hackage.

Further notes

None.

Activity

  1. added
    CR:Type:ManagementAdmin only: Change request for conformance with policies or procedures
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Jan 7, 2024
  2. ivanperez-keera commented on Jan 7, 2024

    @ivanperez-keera
    MemberAuthor

    Change Manager: Confirmed version is ready to be released.

  3. added
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    and removed
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Jan 7, 2024
  4. ivanperez-keera commented on Jan 7, 2024

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Confirmed that the issue should be addressed.

  5. added
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    and removed
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    on Jan 7, 2024
  6. ivanperez-keera commented on Jan 7, 2024

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Issue scheduled for Copilot 3.18.

    Fix assigned to: @ivanperez-keera.

  7. added
    CR:Status:ScheduledAdmin only: Change requested scheduled
    and removed
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    on Jan 7, 2024
  8. added this to the 3.18 milestone on Jan 7, 2024
  9. added
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    and removed
    CR:Status:ScheduledAdmin only: Change requested scheduled
    on Jan 7, 2024
  10. ivanperez-keera commented on Jan 7, 2024

    @ivanperez-keera
    MemberAuthor

    Implementor: Solution implemented, review requested.

  11. added
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    and removed
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    on Jan 8, 2024
  12. ivanperez-keera commented on Jan 8, 2024

    @ivanperez-keera
    MemberAuthor

    Change Manager: Verified that:

    • Solution is implemented:
      • The code proposed compiles and passes all tests. Details:
        Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/268176478

      • The solution proposed addresses the necessary modification to cabal packages. The following docker image installs copilot enforcing the new version via compiler constraints. It prints the message "Success" at the end if all completes correctly, and shows an error message otherwise.

      FROM ubuntu:focal
      
      RUN apt-get update
      
      RUN apt-get install --yes libz-dev
      RUN apt-get install --yes git
      
      RUN apt-get install --yes wget
      RUN mkdir -p $HOME/.ghcup/bin
      RUN wget https://downloads.haskell.org/~ghcup/0.1.17.7/x86_64-linux-ghcup-0.1.17.7 -O $HOME/.ghcup/bin/ghcup
      
      RUN chmod a+x $HOME/.ghcup/bin/ghcup
      ENV PATH=$PATH:/root/.ghcup/bin/
      ENV PATH=$PATH:/root/.cabal/bin/
      RUN apt-get install --yes curl
      RUN apt-get install --yes gcc make libgmp3-dev
      RUN ghcup install ghc 9.0
      RUN ghcup install cabal 3.4
      RUN ghcup set ghc 9.0.2
      RUN cabal update
      
      SHELL ["/bin/bash", "-c"]
      CMD git clone $REPO \
          && cd $NAME \
          && git checkout $COMMIT \
          && cabal install --lib copilot**/ \
               --constraint="copilot==3.18" \
               --constraint="copilot-c99==3.18" \
               --constraint="copilot-core==3.18" \
               --constraint="copilot-prettyprinter==3.18" \
               --constraint="copilot-interpreter==3.18" \
               --constraint="copilot-language==3.18" \
               --constraint="copilot-libraries==3.18" \
               --constraint="copilot-theorem==3.18" \
          && echo Success
      Command (substitute variables based on new path after merge):
      $ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=d3f5a5d99e83a137de03a443d32052a9b205df36" -it copilot-verify-487
      
    • Implementation is documented. Details:
      No changes to the documentation needed (change to fields in cabal).
    • Change history is clear.
    • Commit messages are clear.
    • Changelogs are updated.
    • Examples are updated. Details:
      No examples affected.
    • Required version bumps are evaluated. Details:
      No bump needed (but implemented by the change).
  13. ivanperez-keera commented on Jan 8, 2024

    @ivanperez-keera
    MemberAuthor

    Change Manager: Implementation ready to be merged.

  14. added
    CR:Status:ClosedAdmin only: Change request that has been completed
    and removed
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    on Jan 8, 2024
  15. added a commit that references this issue on Apr 9, 2024
    a53f532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

CR:Status:ClosedAdmin only: Change request that has been completedCR:Type:ManagementAdmin only: Change request for conformance with policies or procedures

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions