copilot-theorem: Extend range of versions of what4

Description

In order to keep Copilot effectively working in the current Haskell ecosystem, as well as new versions of GHC, we need to extend the versions of dependencies that Copilot can be installed with. The package what4 has seen release 1.7, but we depend on versions prior to 1.7.

Type

Management: update versions of dependencies.

Additional context

None.

Requester

Ivan Perez.

Method to check presence of bug

Not applicable (not a bug).

Expected result

Copilot can be installed with the most recent version of what4 published on hackage that do not require a change to the Haskell code.

Desired result

Copilot can be installed with the most recent version of what4 published on hackage that do not require a change to the Haskell code.

Proposed solution

Bump version bounds on what4.

Further notes

None.

Change Manager: Confirmed that the issue exists.

Technical Lead: Confirmed that the issue should be addressed.

copilot-theorem: Bump `what4` upper bound to `< 1.8`. Refs Copilot-La…

copilot-theorem: Document changes in CHANGELOG. Refs Copilot-Language…

@ivanperez-keera

Technical Lead: Issue scheduled for fixing in Copilot 4.5.

Fix assigned to: @ivanperez-keera .

copilot-theorem: Relax version constraint on `what4`. Refs Copilot-La…

copilot-theorem: Document changes in CHANGELOG. Refs Copilot-Language…

Implementor: Solution implemented, review requested.

Change Manager: Verified that:

Solution is implemented:

The code proposed compiles and passes all tests. Details:
Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/275675175

The solution proposed produces the expected result. Details:
The following Dockerfile installs copilot forcing the version of what4 to be greater than or equal to 1.7, after which it prints the message "Success":

FROM ubuntu:focal

ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update

RUN apt-get install --yes \
      libz-dev \
      git \
      curl \
      gcc \
      g++ \
      make \
      libgmp3-dev  \
      pkg-config \
      z3

RUN mkdir -p $HOME/.ghcup/bin
RUN curl https://downloads.haskell.org/~ghcup/0.1.40.0/x86_64-linux-ghcup-0.1.40.0 -o $HOME/.ghcup/bin/ghcup
RUN chmod a+x $HOME/.ghcup/bin/ghcup
ENV PATH=$PATH:/root/.ghcup/bin/
ENV PATH=$PATH:/root/.cabal/bin/

SHELL ["/bin/bash", "-c"]

RUN ghcup install ghc 9.10.1
RUN ghcup install cabal 3.2
RUN ghcup set ghc 9.10.1
RUN cabal update

SHELL ["/bin/bash", "-c"]
CMD git clone $REPO && cd $NAME && git checkout $COMMIT && cd .. \
  && cabal v1-sandbox init \
  && cabal v1-install alex happy --constraint='happy <= 2' \
  && cabal v1-install --constraint='what4 >= 1.7' \
                      $NAME/copilot/ \
                      $NAME/copilot-c99/ \
                      $NAME/copilot-core/ \
                      $NAME/copilot-prettyprinter/ \
                      $NAME/copilot-interpreter/ \
                      $NAME/copilot-language/ \
                      $NAME/copilot-libraries/ \
                      $NAME/copilot-theorem/ \
  && echo "Success"

Command (substitute variables based on new path after merge):

$ docker run -e REPO=https://github.com/ivanperez-keera/copilot -e NAME=copilot -e COMMIT=1f68f7e9d5f09a2a0e6cdd902cfd20d637c30fef copilot-verify-611

Implementation is documented. Details:
No updates needed.
Change history is clear.
Commit messages are clear.
Changelogs are updated.
Examples are updated. Details:
No updates needed.
Author is internal or has provided signed CLA.
Required version bumps are evaluated. Details:
Bump not needed (relaxes version constraints).

Change Manager: Implementation ready to be merged.

Merge branch 'develop-bump-what4-1.7'. Close Copilot-Language#611.

Navigation Menu

Repository navigation

`copilot-theorem`: Extend range of versions of `what4` #611

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

copilot-theorem: Extend range of versions of what4 #611

Description

Activity

ivanperez-keera commented on Mar 29, 2025

ivanperez-keera commented on Mar 29, 2025

ivanperez-keera commented on Jul 6, 2025

ivanperez-keera commented on Jul 6, 2025

ivanperez-keera commented on Jul 6, 2025

ivanperez-keera commented on Jul 6, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`copilot-theorem`: Extend range of versions of `what4` #611