Skip to content

copilot-bluespec: Include in mainline #623

New issue
New issue
Closed
#625
Closed
copilot-bluespec: Include in mainline#623
#625
Assignees
RyanGlScott
Labels
CR:Status:ClosedAdmin only: Change request that has been completedCR:Type:ManagementAdmin only: Change request for conformance with policies or procedures
Milestone
4.5

Description

@ivanperez-keera
ivanperez-keera
opened on May 17, 2025

Description

The copilot-bluespec was developed outside of this repo, but there's interest in having all Copilot projects and libraries merged into a main repo for ease of management.

Type

  • Management: files need to be moved between repos.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

Not applicable (not a bug).

Expected result

The last state of the copilot-bluespec is included in this repository, disregarding history, and adjusting the changelog to make the old issues refer to copilot-bluespec#<ISSUE_NUM> so that they are not interpreted as related to the main Copilot repo.

Desired result

The last state of the copilot-bluespec is included in this repository, disregarding history, and adjusting the changelog to make the old issues refer to copilot-bluespec#<ISSUE_NUM> so that they are not interpreted as related to the main Copilot repo.

Proposed solution

Copy last state of copilot-bluespec as subdirectory of main repo.

Adjust Changelog in copilot-bluespec to make older issues point to correct repo.

Further notes

None.

Activity

  1. ivanperez-keera
    added
    CR:Type:ManagementAdmin only: Change request for conformance with policies or procedures
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on May 17, 2025

  2. ivanperez-keera commented on May 17, 2025

    @ivanperez-keera
    ivanperez-keera
    on May 17, 2025
    MemberAuthor

    Change Manager: Confirmed that the issue exists.

  3. ivanperez-keera
    added
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    and removed
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on May 17, 2025

  4. ivanperez-keera commented on May 17, 2025

    @ivanperez-keera
    ivanperez-keera
    on May 17, 2025
    MemberAuthor

    Technical Lead: Confirmed that the issue should be addressed.

  5. ivanperez-keera
    added
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    and removed
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    on May 17, 2025

  6. ivanperez-keera commented on May 17, 2025

    @ivanperez-keera
    ivanperez-keera
    on May 17, 2025
    MemberAuthor

    Technical Lead: Issue scheduled for fixing in Copilot 4.5.

    Fix assigned to: @RyanGlScott .

  7. ivanperez-keera
    added
    CR:Status:ScheduledAdmin only: Change requested scheduled
    and removed
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    on May 17, 2025
  8. ivanperez-keera
    assigned
    RyanGlScott
    on May 17, 2025
  9. ivanperez-keera
    added this to the 4.5 milestone on May 17, 2025
  10. RyanGlScott
    added 2 commits that reference this issue on May 19, 2025

    copilot-bluespec: Include in mainline copilot repo. Refs Copilot-Lang…

    28a0cc6

    copilot-bluespec: Document changes in CHANGELOG. Refs Copilot-Languag…

    5555c1d

  11. 11 remaining items

  12. RyanGlScott commented on May 28, 2025

    @RyanGlScott
    RyanGlScott
    on May 28, 2025
    Collaborator

    Implementor: Solution implemented, review requested.

  13. ivanperez-keera
    added
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    and removed
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    on May 30, 2025
  14. RyanGlScott
    added 2 commits that reference this issue on Jun 3, 2025

    copilot-bluespec: Include in mainline copilot repo. Refs Copilot-Lang…

    7443dc8

    copilot-bluespec: Document changes in CHANGELOG. Refs Copilot-Languag…

    d3ea6cd
  15. RyanGlScott
    added 4 commits that reference this issue on Jun 18, 2025

    copilot-bluespec: Include in mainline copilot repo. Refs Copilot-Lang…

    39955b8

    copilot-bluespec: Document changes in CHANGELOG. Refs Copilot-Languag…

    7de768e

    copilot-bluespec: Adjust issue numbers in changelog. Refs Copilot-Lan…

    5467481

    copilot-bluespec: Document changes in CHANGELOG. Refs Copilot-Languag…

    7433ba3

  16. ivanperez-keera commented on Jun 19, 2025

    @ivanperez-keera
    ivanperez-keera
    on Jun 19, 2025
    MemberAuthor

    Change Manager: Verified that:

    • Solution is implemented:
      • The code proposed compiles and passes all tests. Details:
        Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/275533476
      • The solution proposed produces the expected result. Details:
        The following dockerfile checks out the latest version of copilot-bluespec, v4.4, and compares it against the version being merged, ignoring changes in expected files, namely those related to Git, Github or the CHANGELOG, checking that there are no other differences, after which it prints the message "Success": 
        FROM ubuntu:noble

ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update

RUN apt-get install --yes git
RUN git config --global advice.detachedHead false

CMD git clone $REPO $NAME \
    && cd $NAME \
    && git checkout $COMMIT \
    && cd .. \
    && git clone -b v4.4 https://github.com/Copilot-Language/copilot-bluespec copilot-bluespec-original \
    && diff --exclude '.git' --exclude '.github' --exclude '.gitignore' --exclude 'CHANGELOG' -r $NAME/copilot-bluespec copilot-bluespec-original \
    && echo "Success"
        Command (substitute variables based on new path after merge): 
        $ docker run -e REPO=https://github.com/GaloisInc/copilot-1 -e NAME=copilot -e COMMIT=7433ba32d87727f947357f78293bd8b900bba0f6 copilot-verify-623
    • Implementation is documented. Details:
      CHANGELOG updated to make old issues point to original repo. No other changes needed.
    • Change history is clear.
    • Commit messages are clear.
    • Changelogs are updated.
    • Examples are updated. Details:
      No updates needed.
    • Required version bumps are evaluated. Details:
      Bump not needed; change imports existing package without affecting API.

  17. ivanperez-keera commented on Jun 19, 2025

    @ivanperez-keera
    ivanperez-keera
    on Jun 19, 2025
    MemberAuthor

    Change Manager: Implementation ready to be merged.

  18. ivanperez-keera
    closed this as completedin 280b1f8on Jun 19, 2025
  19. ivanperez-keera
    added
    CR:Status:ClosedAdmin only: Change request that has been completed
    and removed
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    on Jun 19, 2025
  20. RyanGlScott
    added a commit that references this issue on Jun 20, 2025

    Merge branch 'develop-copilot-bluespec-upstream'. Close Copilot-Langu…

    280b1f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CR:Status:ClosedAdmin only: Change request that has been completedCR:Type:ManagementAdmin only: Change request for conformance with policies or procedures

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions