copilot-theorem: Copilot.Theorem.Misc.SExpr.parseSExpr is unused

Description

The function copilot-theorem:Copilot.Theorem.Misc.SExpr.parseSExpr is not used anywhere in the implementation. The module is internal and not exposed to the user, so that function does not have and cannot have any users.

Type

Bug: unused code included in the implementation.

Additional context

None.

Requester

Ivan Perez.

Method to check presence of bug

The following search finds mentions of parseSExpr in the implementation, showing only the definition:

$ grep -nHre 'parseSExpr' copilot**/src copilot**/tests
copilot-theorem/src/Copilot/Theorem/Misc/SExpr.hs:103:parseSExpr :: String -> Maybe (SExpr String)
copilot-theorem/src/Copilot/Theorem/Misc/SExpr.hs:104:parseSExpr str = case parse parser "" str of

Expected result

The string should be either empty (the function does not exist) or list further uses.

Desired result

The string should be either empty (the function does not exist) or list further uses.

Proposed solution

Removing the function from the module Copilot.Theorem.Misc.SExpr.parseSExpr, as well as any auxiliary functions or imports exclusively needed by that function, if any.

Further notes

None.

Change Manager: Confirmed that the issue exists.

Technical Lead: Confirmed that the issue should be addressed.

@ivanperez-keera

Technical Lead: Issue scheduled for fixing in Copilot 4.5.1.

Fix assigned to: @ivanperez-keera .

EDIT: Milestone renamed from 4.6 to 4.5.1.

copilot-theorem: Remove unused function parseSExpr. Refs Copilot-Lang…

copilot-theorem: Removed unnecessary dependency on parsec. Refs Copil…

copilot-theorem: Document changes in CHANGELOG. Refs Copilot-Language…

copilot-theorem: Remove unused function Copilot.Theorem.Misc.SExpr.pa…

copilot-theorem: Removed unnecessary dependency on parsec. Refs Copil…

copilot-theorem: Document changes in CHANGELOG. Refs Copilot-Language…

Implementor: Solution implemented, review requested.

Change Manager: Verified that:

Solution is implemented:
- The code proposed compiles and passes all tests. Details:
  Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/276239475
- The solution proposed produces the expected result. Details:
  The following dockerfile checks that parseSExpr is not mentioned anywhere in the code, after which it prints the message "Success":
```
FROM ubuntu:jammy

RUN apt-get update
RUN apt-get install --yes git

SHELL ["/bin/bash", "-c"]
CMD git clone $REPO \
  && cd $NAME \
  && git checkout $COMMIT \
  && ! grep -nHre '\<parseSExpr\>' --include='*.hs' \
  && echo "Success"
```
  Command (substitute variables based on new path after merge):
```
$ docker run -e "REPO=https://github.com/ivanperez-keera/copilot" -e "NAME=copilot" -e "COMMIT=b0d5e2bc652ff4cb3cd15e977ee49e503501dafa" -it copilot-verify-661
```
Implementation is documented. Details:
The documentation is updated to reflect that parsing is no longer supported for SExpr.
Change history is clear.
Commit messages are clear.
Changelogs are updated.
Examples are updated. Details:
Update not needed; change does not affect examples.
Author is internal or has provided signed CLA.
Required version bumps are evaluated. Details:
Bump not needed; change does not affect public API.

Change Manager: Implementation ready to be merged.

Merge branch 'develop-remove-parseSExpr'. Close Copilot-Language#661.

Navigation Menu

Repository navigation

`copilot-theorem`: `Copilot.Theorem.Misc.SExpr.parseSExpr` is unused #661

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

copilot-theorem: Copilot.Theorem.Misc.SExpr.parseSExpr is unused #661

Description

Activity

ivanperez-keera commented on Sep 7, 2025

ivanperez-keera commented on Sep 7, 2025

ivanperez-keera commented on Sep 7, 2025

ivanperez-keera commented on Sep 7, 2025

ivanperez-keera commented on Sep 7, 2025

ivanperez-keera commented on Sep 7, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`copilot-theorem`: `Copilot.Theorem.Misc.SExpr.parseSExpr` is unused #661