Skip to content

copilot-bluespec: CHANGELOG contains tab #755

Closed

Description

@ivanperez-keera

Description

The changelog of the copilot-bluespec package contains a tab character.

Per our style guide, we should not use tabs anywhere in code, READMEs or CHANGELOGs, unless strictly necessary.

Type

  • Bug: Changelog contains tab.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

Searching for tabs in the CHANGELOG reveals the existence of a tab:

$ grep -nHre $'\t'   copilot-bluespec/CHANGELOG 
copilot-bluespec/CHANGELOG:14:	* Fix translation of constant floating-point values. (#696)

Expected result

The CHANGELOG of copilot-bluespec contains no tabs.

Desired result

The CHANGELOG of copilot-bluespec contains no tabs.

Proposed solution

Replace any tabs in the CHANGELOG of copilot-bluespec with spaces.

Further notes

None.

Activity

  1. added
    CR:Type:BugAdmin only: Change request pertaining to error detected
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Sep 8, 2026
  2. ivanperez-keera commented on Sep 8, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Confirmed that the issue exists.

  3. added
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    and removed
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Sep 8, 2026
  4. ivanperez-keera commented on Sep 8, 2026

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Confirmed that the issue should be addressed.

  5. added
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    and removed
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    on Sep 8, 2026
  6. ivanperez-keera commented on Sep 8, 2026

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Issue scheduled for fixing in Copilot 4.8.1.

    Fix assigned to: @ivanperez-keera .

  7. added
    CR:Status:ScheduledAdmin only: Change requested scheduled
    and removed
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    on Sep 8, 2026
  8. added this to the 4.8.1 milestone on Sep 8, 2026
  9. added
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    and removed
    CR:Status:ScheduledAdmin only: Change requested scheduled
    on Sep 8, 2026
  10. ivanperez-keera commented on Sep 8, 2026

    @ivanperez-keera
    MemberAuthor

    Implementor: Solution implemented, review requested.

  11. added
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    and removed
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    on Sep 8, 2026
  12. ivanperez-keera commented on Sep 8, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Verified that:

    • Solution is implemented:
      • The code proposed compiles and passes all tests. Details:
        Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/278781996
      • The solution proposed produces the expected result. Details:
        The following Dockerfile checks that the CHANGELOG of copilot-bluespec does not contain any tabs, after which it prints the message "Success":
        --- Dockerfile-verify-755
        FROM ubuntu:jammy
        
        WORKDIR /root
        SHELL ["/bin/bash", "-c"]
        
        ENV DEBIAN_FRONTEND=noninteractive
        RUN apt-get update
        
        RUN apt-get install --yes \
              git
        
        ARG GIT_COMMIT=HEAD
        ARG NAME=copilot
        ARG REPO=https://github.com/copilot-language/copilot
        
        RUN git clone ${REPO} ${NAME}
        RUN cd ${NAME} && git checkout ${GIT_COMMIT}
        
        WORKDIR ${NAME}
        
        RUN ! grep -nHre $'\t' copilot-bluespec/CHANGELOG
        RUN echo "Success"
        Command (substitute variables based on new path after merge):
        $ docker build --build-arg "REPO=https://github.com/ivanperez-keera/copilot" --build-arg "NAME=copilot" --build-arg "GIT_COMMIT=181d8033634c91cb747ef3b59c57dded2d3fbc04" -t copilot-verify-755 -f Dockerfile-verify-755 .
        
    • Implementation is documented. Details:
      No updates needed; change is to a CHANGELOG.
    • Change history is clear.
    • Commit messages are clear.
    • Changelogs are updated.
    • Examples are updated. Details:
      No updates needed; change is to a CHANGELOG.
    • Author is internal or has provided signed CLA.
    • Required version bumps are evaluated. Details:
      Bump not needed; change is to a CHANGELOG and does not affect code or public API.
  13. ivanperez-keera commented on Sep 8, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Implementation ready to be merged.

  14. added
    CR:Status:ClosedAdmin only: Change request that has been completed
    and removed
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    on Sep 8, 2026
  15. added a commit that references this issue on Oct 27, 2026
    d108e0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

CR:Status:ClosedAdmin only: Change request that has been completedCR:Type:BugAdmin only: Change request pertaining to error detected

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions