Skip to content

Multiple files contain tabs #772

Closed
Closed

Description

@ivanperez-keera

Description

Several files across the codebase contain tabs, including the DESIGN.md file in copilot-bluespec, the CHANGELOG for copilot-core, and the Eval module in copilot-interpreter.

Per our style guide, we should not use tabs anywhere in code, READMEs or CHANGELOGs, unless strictly necessary.

Type

  • Bug: Files contain tabs.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

Searching for tabs in the codebase reveals the existence of several tabs:

$ grep -nIHre $'\t' *
copilot-bluespec/DESIGN.md:421:       RST_N,
copilot-bluespec/DESIGN.md:423:       even_guard,
copilot-bluespec/DESIGN.md:425:       even_arg0,
copilot-bluespec/DESIGN.md:427:       odd_guard,
copilot-bluespec/DESIGN.md:429:       odd_arg0);
copilot-bluespec/DESIGN.md:818:       RST_N,
copilot-bluespec/DESIGN.md:820:       even_guard,
copilot-bluespec/DESIGN.md:822:       even_arg0,
copilot-bluespec/DESIGN.md:824:       odd_guard,
copilot-bluespec/DESIGN.md:826:       odd_arg0,
copilot-bluespec/DESIGN.md:828:       fibs);
copilot-core/CHANGELOG:2:       * Increase test coverage for `Copilot.Core.Type.Array`. (#767)
copilot-interpreter/src/Copilot/Interpret/Eval.hs:22:                           arrayElems, arrayUpdate, specObservers,

Expected result

No source files, Cabal files, documentation or CHANGELOGs in the Copilot project contain tabs.

Desired result

No source files, Cabal files, documentation or CHANGELOGs in the Copilot project contain tabs.

Proposed solution

Replace any tabs in any source files, Cabal files, documentation or CHANGELOGs in the Copilot project with spaces.

Further notes

None.

Activity

  1. added
    CR:Type:BugAdmin only: Change request pertaining to error detected
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Oct 12, 2026
  2. ivanperez-keera commented on Oct 12, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Confirmed that the issue exists.

  3. added
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    and removed
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Oct 12, 2026
  4. ivanperez-keera commented on Oct 12, 2026

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Confirmed that the issue should be addressed.

  5. added
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    and removed
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    on Oct 12, 2026
  6. ivanperez-keera commented on Oct 12, 2026

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Issue scheduled for fixing in Copilot 4.8.2.

    Fix assigned to: @ivanperez-keera.

  7. added
    CR:Status:ScheduledAdmin only: Change requested scheduled
    and removed
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    on Oct 12, 2026
  8. added this to the 4.8.2 milestone on Oct 12, 2026
  9. added
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    and removed
    CR:Status:ScheduledAdmin only: Change requested scheduled
    on Oct 12, 2026
  10. ivanperez-keera commented on Oct 12, 2026

    @ivanperez-keera
    MemberAuthor

    Implementor: Solution implemented, review requested.

  11. added
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    and removed
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    on Oct 12, 2026
  12. ivanperez-keera commented on Oct 12, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Verified that:

    • Solution is implemented:
      • The code proposed compiles and passes all tests. Details:
        Build log: https://app.travis-ci.com/github/Copilot-Language/copilot/builds/278978093
      • The solution proposed produces the expected result. Details:
        The following Dockerfile checks that no files that are not binary contain any tabs, after which it prints the message "Success":
        --- Dockerfile-verify-772
        FROM ubuntu:jammy
        
        WORKDIR /root
        SHELL ["/bin/bash", "-c"]
        
        ENV DEBIAN_FRONTEND=noninteractive
        RUN apt-get update
        
        RUN apt-get install --yes \
              git
        
        ARG GIT_COMMIT=HEAD
        ARG NAME=copilot
        ARG REPO=https://github.com/copilot-language/copilot
        
        RUN git clone ${REPO} ${NAME}
        RUN cd ${NAME} && git checkout ${GIT_COMMIT}
        
        WORKDIR ${NAME}
        
        RUN ! grep -nIHre $'\t' *
        RUN echo "Success"
        Command (substitute variables based on new path after merge):
        $ docker build --build-arg "REPO=https://github.com/ivanperez-keera/copilot" --build-arg "NAME=copilot" --build-arg "GIT_COMMIT=d00808a471e635c470444edcaaa89478ee9fb0c9" -t copilot-verify-772 -f Dockerfile-verify-772 .
        
    • Implementation is documented. Details:
      No updates needed; change does not affect code behavior or documentation.
    • Change history is clear.
    • Commit messages are clear.
    • Changelogs are updated.
    • Examples are updated. Details:
      No updates needed; change does not affect existing examples.
    • Author is internal or has provided signed CLA.
    • Required version bumps are evaluated. Details:
      Bump not needed; the change only alters the format and does not affect code or public API.
  13. ivanperez-keera commented on Oct 12, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Implementation ready to be merged.

  14. added a commit that references this issue on Oct 12, 2026
    0fa4d5e
  15. added
    CR:Status:ClosedAdmin only: Change request that has been completed
    and removed
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    on Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

CR:Status:ClosedAdmin only: Change request that has been completedCR:Type:BugAdmin only: Change request pertaining to error detected

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions