Skip to content

copilot-core: Descriptions of two tests in Test.Copilot.Core.Type are incorrect #781

Closed

Description

@ivanperez-keera

Description

The Haddock comments that accompany the properties testUpdateStruct and testUpdateStruct, included in the test module copilot-core:Test.Copilot.Core.Type, are incorrect. The comments indicate that the properties test showing a struct, when they are related to updates instead.

All Haddock comments should correctly document the functionality implemented in Copilot.

Type

  • Bug: Incorrect Haddock comments in tests.

Additional context

None.

Requester

  • Ivan Perez.

Method to check presence of bug

This can only be checked by visual inspection, since the comment is written in plain English and we don't have an automated way of validating them.

Expected result

All Haddock comments for properties in the test modules correctly describe the functionality being tested.

Desired result

All Haddock comments for properties in the test modules correctly describe the functionality being tested.

Proposed solution

Fix the comments of testUpdateStruct and testUpdateStruct, in the test module copilot-core:Test.Copilot.Core.Type, to correctly indicate that they pertain to tests (in the positive and negative case, respectively).

Further notes

None.

Activity

  1. added
    CR:Type:BugAdmin only: Change request pertaining to error detected
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Oct 16, 2026
  2. ivanperez-keera commented on Oct 16, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Confirmed that the issue exists.

  3. added
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    and removed
    CR:Status:InitiatedAdmin only: Change request that has been initiated
    on Oct 16, 2026
  4. ivanperez-keera commented on Oct 16, 2026

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Confirmed that the issue should be addressed.

  5. added
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    and removed
    CR:Status:ConfirmedAdmin only: Change request that has been acknowledged by the change manager
    on Oct 16, 2026
  6. ivanperez-keera commented on Oct 16, 2026

    @ivanperez-keera
    MemberAuthor

    Technical Lead: Issue scheduled for fixing in Copilot 4.8.2.

    Fix assigned to: @kavehz-nasa.

  7. added
    CR:Status:ScheduledAdmin only: Change requested scheduled
    and removed
    CR:Status:AcceptedAdmin only: Change request accepted by technical lead
    on Oct 16, 2026
  8. added this to the 4.8.2 milestone on Oct 16, 2026
  9. added
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    and removed
    CR:Status:ScheduledAdmin only: Change requested scheduled
    on Oct 16, 2026
  10. kavehz-nasa commented on Oct 16, 2026

    @kavehz-nasa
    Collaborator

    Implementor: Solution implemented, review requested.

  11. added
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    and removed
    CR:Status:ImplementationAdmin only: Change request that is currently being implemented
    on Oct 16, 2026
  12. ivanperez-keera commented on Oct 16, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Verified that:

    • Solution is implemented:
    • Implementation is documented. Details:
      Change is to the documentation of two definitions.
    • Change history is clear.
    • Commit messages are clear.
    • Changelogs are updated.
    • Examples are updated. Details:
      No updates needed; the change does not affect the existing examples.
    • Author is internal or has provided signed CLA.
    • Required version bumps are evaluated. Details:
      Bump not needed; the change does not affect the public API.
  13. ivanperez-keera commented on Oct 16, 2026

    @ivanperez-keera
    MemberAuthor

    Change Manager: Implementation ready to be merged.

  14. added
    CR:Status:ClosedAdmin only: Change request that has been completed
    and removed
    CR:Status:VerificationAdmin only: Change request that is currently being verified
    on Oct 16, 2026
  15. added a commit that references this issue on Oct 27, 2026
    8d9e367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CR:Status:ClosedAdmin only: Change request that has been completedCR:Type:BugAdmin only: Change request pertaining to error detected

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions