feat(functions): add scope=selection to diagnostics - #1351
Merged
deathbeam merged 6 commits intoAug 25, 2025
Conversation
Adds a new scope to the diagnostics function where the user specifies that only diagnostics found inside the visual selection are to be included in the prompt's context.
Collaborator
|
This should probably wait for #1340 as there will be only single api for selection with it (as currently the selection module has 4 apis and this is hardcoding the visual one here) |
Collaborator
|
Ok #1340 was merged so now the selection is just select.get(source.bufnr) |
Contributor
Author
@deathbeam cheers, I updated the selection call |
deathbeam
requested changes
Aug 25, 2025
deathbeam
reviewed
Aug 25, 2025
- no need for scope conditional bc we're using the whole buffer as default selection - pass buffer id when using selection.get - return early if mode is selection but there's nothing selected
deathbeam
reviewed
Aug 25, 2025
Collaborator
|
awesome, thanks! @all-contributors add @ruicsh for code |
Contributor
|
I've put up a pull request to add @ruicsh! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new scope to the diagnostics function where the user specifies that only diagnostics found inside the visual selection are to be included in the prompt's context.
This implements #1350